fix(agent): skip external memory providers in background review agent - #24281
Closed
DanielMaly wants to merge 1 commit into
Closed
fix(agent): skip external memory providers in background review agent#24281DanielMaly wants to merge 1 commit into
DanielMaly wants to merge 1 commit into
Conversation
The background self-improvement review agent was initializing external memory providers (e.g. Honcho) because skip_memory defaulted to False. This caused the review prompt to be written as a user message, polluting peer representations with agent-internal system instructions. - Pass skip_memory=True to the review agent constructor in _spawn_background_review() so external providers never initialize - Add 'background_review' and 'subagent' to the Honcho plugin's cron guard as defense-in-depth, matching supermemory's existing behavior Closes NousResearch#4052 (cron case was fixed, but background review path was missed)
alt-glitch
added
type/bug
Author
|
Closing this because the main functional fix landed upstream independently in #27190 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopened from #21511 (auto-closed during fork sync).
The background review agent was inadvertently calling external memory providers (Honcho, etc.) during its review cycles, which:
This fix adds a check to skip external memory provider calls when the agent is running in background review mode.