Skip to content

fix(agent): skip external memory providers in background review agent #24281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielMaly wants to merge 1 commit into from
Closed

fix(agent): skip external memory providers in background review agent #24281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions plugins/memory/honcho/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,12 @@ def initialize(self, session_id: str, **kwargs) -> None:
"""
try:
# ----- Port #4053: cron guard -----
# Also covers background_review and subagent contexts to prevent
# non-user-facing agents from polluting peer representations.
agent_context = kwargs.get("agent_context", "")
platform = kwargs.get("platform", "cli")
if agent_context in ("cron", "flush") or platform == "cron":
logger.debug("Honcho skipped: cron/flush context (agent_context=%s, platform=%s)",
if agent_context in ("cron", "flush", "background_review", "subagent") or platform == "cron":
logger.debug("Honcho skipped: non-primary context (agent_context=%s, platform=%s)",
agent_context, platform)
self._cron_skipped = True
return
Expand Down
1 change: 1 addition & 0 deletions run_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4297,6 +4297,7 @@ def _bg_review_auto_deny(command, description, **kwargs):
credential_pool=getattr(self, "_credential_pool", None),
parent_session_id=self.session_id,
enabled_toolsets=["memory", "skills"],
skip_memory=True,
)
review_agent._memory_write_origin = "background_review"
review_agent._memory_write_context = "background_review"
Expand Down