fix(agent): skip external memory providers in background review agent - #21511
Closed
DanielMaly wants to merge 0 commit into
Closed
fix(agent): skip external memory providers in background review agent#21511DanielMaly wants to merge 0 commit into
DanielMaly wants to merge 0 commit into
Conversation
alt-glitch
added
type/bug
DanielMaly
force-pushed
the
fix/background-review-honcho-leak
branch
2 times, most recently
from
May 9, 2026 19:42
6e8901f to
d6007b4
Compare
Closed
6 tasks
DanielMaly
force-pushed
the
fix/background-review-honcho-leak
branch
from
May 10, 2026 19:00
d6007b4 to
bbc9964
Compare
DanielMaly
force-pushed
the
fix/background-review-honcho-leak
branch
from
May 11, 2026 05:01
bbc9964 to
3b122cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevents the background self-improvement review agent from writing to external memory providers (Honcho, etc.).
Why
_spawn_background_review()creates a forkedAIAgentwithskip_memory=False(default). This causes external memory providers to initialize and write the review prompt as a user message, polluting peer representations with agent-internal system instructions (e.g. skill management preferences).This is the same class of bug as #4052, which fixed the cron path but missed the background review path.
Changes
run_agent.py: Passskip_memory=Trueto the review agent constructor. The review agent only needs built-inmemoryandskillstools — external providers are unnecessary and harmful.plugins/memory/honcho/__init__.py: Add"background_review"and"subagent"to the cron guard check as defense-in-depth, matching the supermemory plugin's existing behavior.Testing
test_background_review*tests pass (3/3)background_reviewandsubagentcontextsCloses #21510