fix(kanban): COLUMN_LABEL → FALLBACK_COLUMN_LABEL typo in aria-label - #23901
Closed
herrschmidt wants to merge 1 commit into
Closed
fix(kanban): COLUMN_LABEL → FALLBACK_COLUMN_LABEL typo in aria-label#23901herrschmidt wants to merge 1 commit into
herrschmidt wants to merge 1 commit into
Conversation
The i18n merge introduced FALLBACK_COLUMN_LABEL but one aria-label template literal still referenced the undefined COLUMN_LABEL, causing a rendering crash in the Kanban dashboard tab.
Collaborator
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
austinpickett
requested changes
May 18, 2026
austinpickett
left a comment
Collaborator
There was a problem hiding this comment.
use PULL_REQUEST_TEMPLATE.md
Contributor
|
Thanks for catching this @herrschmidt — closing as already-resolved. The aria-label was fixed independently in commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The i18n merge (b8bf2f8) introduced
FALLBACK_COLUMN_LABELbut one aria-label template literal still referenced the undefinedCOLUMN_LABEL, causing a rendering crash in the Kanban dashboard tab.Root Cause
plugins/kanban/dashboard/dist/index.jsline 1901 usedCOLUMN_LABELinstead ofFALLBACK_COLUMN_LABEL(which is the actual constant defined on line 59).Fix
One-line change:
COLUMN_LABEL→FALLBACK_COLUMN_LABELin the checkbox aria-label.