Skip to content

fix(kanban): COLUMN_LABEL → FALLBACK_COLUMN_LABEL typo in aria-label - #23901

Closed
herrschmidt wants to merge 1 commit into
NousResearch:mainfrom
herrschmidt:fix/kanban-column-label-typo
Closed

fix(kanban): COLUMN_LABEL → FALLBACK_COLUMN_LABEL typo in aria-label#23901
herrschmidt wants to merge 1 commit into
NousResearch:mainfrom
herrschmidt:fix/kanban-column-label-typo

Conversation

@herrschmidt

Copy link
Copy Markdown

Summary

The i18n merge (b8bf2f8) introduced FALLBACK_COLUMN_LABEL but one aria-label template literal still referenced the undefined COLUMN_LABEL, causing a rendering crash in the Kanban dashboard tab.

Root Cause

plugins/kanban/dashboard/dist/index.js line 1901 used COLUMN_LABEL instead of FALLBACK_COLUMN_LABEL (which is the actual constant defined on line 59).

Fix

One-line change: COLUMN_LABELFALLBACK_COLUMN_LABEL in the checkbox aria-label.

The i18n merge introduced FALLBACK_COLUMN_LABEL but one aria-label
template literal still referenced the undefined COLUMN_LABEL, causing
a rendering crash in the Kanban dashboard tab.
@alt-glitch alt-glitch added type/bug Something isn't working comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels May 11, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #23637 — same COLUMN_LABEL → FALLBACK_COLUMN_LABEL one-line fix for #23620. This is the N-th competing PR for this issue (see also #23659, #23701, #23780, #23832).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@austinpickett austinpickett left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use PULL_REQUEST_TEMPLATE.md

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for catching this @herrschmidt — closing as already-resolved. The aria-label was fixed independently in commit 27cfe7254 fix(kanban): use localized column label in select-all aria label which moved past the COLUMN_LABEL constant entirely (now uses colLabel pattern). Your fix would have produced the same result. Appreciate the contribution!

@teknium1 teknium1 closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants