Skip to content

fix(kanban): prevent column label render crash - #23780

Closed
KattiTronics wants to merge 1 commit into
NousResearch:mainfrom
KattiTronics:fix/kanban-column-label-crash
Closed

fix(kanban): prevent column label render crash#23780
KattiTronics wants to merge 1 commit into
NousResearch:mainfrom
KattiTronics:fix/kanban-column-label-crash

Conversation

@KattiTronics

Copy link
Copy Markdown

Summary

  • Fixes Kanban dashboard render crash caused by COLUMN_LABEL being undefined in the column select-all checkbox aria-label.
  • Reuses the already computed localized colLabel, matching the visible column heading and preserving the existing fallback to the raw column name.

Test Plan

  • node --check plugins/kanban/dashboard/dist/index.js
  • Loaded /kanban in the local dashboard and verified the board renders without console errors.
  • Hermes Kanban CLI still lists boards/tasks.

Notes

This does not include Richard's local cache-bust manifest change; that was only needed to force his running browser/dashboard to stop using a stale plugin bundle after the local hotfix.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists labels May 11, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #23659. Same fix for COLUMN_LABEL ReferenceError in kanban dashboard select-all checkbox. Also duplicated by #23701.

@teknium1

Copy link
Copy Markdown
Contributor

Closing as already fixed on current main — plugins/kanban/dashboard/dist/index.js:1901 already reads \Select all tasks in ${colLabel || props.column.name}``, which is exactly your proposed change. The bundle was regenerated from source between when you opened this PR and now. Thanks for spotting and fixing the issue — your contribution was the reason it landed.

@teknium1 teknium1 closed this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants