fix(kanban): use colLabel for column select-all aria-label - #23832
Closed
liuhao1024 wants to merge 1 commit into
Closed
fix(kanban): use colLabel for column select-all aria-label#23832liuhao1024 wants to merge 1 commit into
liuhao1024 wants to merge 1 commit into
Conversation
Use the already-computed colLabel (from getColumnLabel() via tx() i18n fallback) instead of directly referencing the undefined COLUMN_LABEL variable. This follows the same i18n pattern used by the column title span on the adjacent line. Previously the aria-label referenced the deleted COLUMN_LABEL variable (renamed to FALLBACK_COLUMN_LABEL during the i18n refactor), causing a ReferenceError at render time. Fixes NousResearch#23620
Collaborator
Contributor
Author
|
Closing as duplicate of #23780 (the canonical PR for this fix, as noted by @alt-glitch). The COLUMN_LABEL→colLabel fix is already covered there. |
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ReferenceError: COLUMN_LABEL is not definedin the Kanban dashboard column select-all checkboxaria-label.Root Cause
During the i18n refactor (commit
c3916845), the top-level English dictionaryCOLUMN_LABELwas renamed toFALLBACK_COLUMN_LABEL, but the reference atdist/index.js:1901was not updated. This causes aReferenceErrorat render time when the column checkbox input is mounted.Fix
Replace the undefined
COLUMN_LABEL[props.column.name]with the already-computedcolLabellocal variable (line 1882), which goes throughgetColumnLabel(t, props.column.name)→tx()i18n fallback. This is the same pattern used by the column title span on the adjacent line.Before:
After:
Testing
Verified that
colLabelis computed on line 1882 viagetColumnLabel(t, props.column.name)and is already used by the column title span. Thearia-labelnow respects translations instead of always falling back to English.Fixes [Bug]: Kanban dashboard: COLUMN_LABEL undefined in aria-label at column select-all checkbox #23620