Skip to content

fix(kanban): use colLabel for column select-all aria-label - #23832

Closed
liuhao1024 wants to merge 1 commit into
NousResearch:mainfrom
liuhao1024:fix/kanban-column-label-aria-23620
Closed

fix(kanban): use colLabel for column select-all aria-label#23832
liuhao1024 wants to merge 1 commit into
NousResearch:mainfrom
liuhao1024:fix/kanban-column-label-aria-23620

Conversation

@liuhao1024

Copy link
Copy Markdown
Contributor

Summary

Fix ReferenceError: COLUMN_LABEL is not defined in the Kanban dashboard column select-all checkbox aria-label.

Root Cause

During the i18n refactor (commit c3916845), the top-level English dictionary COLUMN_LABEL was renamed to FALLBACK_COLUMN_LABEL, but the reference at dist/index.js:1901 was not updated. This causes a ReferenceError at render time when the column checkbox input is mounted.

Fix

Replace the undefined COLUMN_LABEL[props.column.name] with the already-computed colLabel local variable (line 1882), which goes through getColumnLabel(t, props.column.name)tx() i18n fallback. This is the same pattern used by the column title span on the adjacent line.

Before:

"aria-label": `Select all tasks in ${COLUMN_LABEL[props.column.name] || props.column.name}`,

After:

"aria-label": `Select all tasks in ${colLabel || props.column.name}`,

Testing

Verified that colLabel is computed on line 1882 via getColumnLabel(t, props.column.name) and is already used by the column title span. The aria-label now respects translations instead of always falling back to English.

Fixes [Bug]: Kanban dashboard: COLUMN_LABEL undefined in aria-label at column select-all checkbox #23620

Use the already-computed colLabel (from getColumnLabel() via tx() i18n
fallback) instead of directly referencing the undefined COLUMN_LABEL
variable. This follows the same i18n pattern used by the column title
span on the adjacent line.

Previously the aria-label referenced the deleted COLUMN_LABEL variable
(renamed to FALLBACK_COLUMN_LABEL during the i18n refactor), causing a
ReferenceError at render time.

Fixes NousResearch#23620
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists labels May 11, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #23780 — Same COLUMN_LABEL→colLabel fix for kanban dashboard aria-label. #23780 is the canonical open PR for this issue (#23620).

@liuhao1024

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #23780 (the canonical PR for this fix, as noted by @alt-glitch). The COLUMN_LABEL→colLabel fix is already covered there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants