fix(plugins): enable aliases using manifest names - #18009
liuhao1024 wants to merge 2 commits into
Conversation
Store the manifest-declared plugin key when enabling a plugin by its installation directory so the list command reports the same plugin as enabled.
|
Hi @liuhao1024 — the PR correctly adds Suggest adding a symmetric test: class TestCmdDisable:
def test_disable_by_directory_stores_manifest_name(self, ...):
cmd_disable("ping_island")
assert _get_disabled_set() == {"ping-island"}Mirrors the enable test and locks in that the resolver runs on both sides. |
- Added TestCmdDisable.test_disable_by_directory_stores_manifest_name - Mirrors the enable test: verifies _resolve_plugin_config_name runs on both cmd_enable and cmd_disable paths Addresses review feedback from @Tranquil-Flow on NousResearch#18009.
Add the two commit emails used by liuhao1024: - liuhao1024@users.noreply.github.com (GitHub noreply) - sunsky.lau@gmail.com (personal) These were flagged by the Contributor Attribution Check CI on PRs NousResearch#18734, NousResearch#18491, NousResearch#18009, and NousResearch#17761.
|
@Tranquil-Flow Good catch — the symmetric disable test was already added in class TestCmdDisable:
def test_disable_by_directory_stores_manifest_name(self, tmp_path, monkeypatch):
...
cmd_enable("ping_island")
assert _get_enabled_set() == {"ping-island"}
cmd_disable("ping_island")
assert _get_disabled_set() == {"ping-island"}
assert "ping-island" not in _get_enabled_set()All 55 plugin tests pass clean. Thanks for the thorough review! |
|
Thanks for the focused plugin-alias fix. This automated hermes-sweeper review found that current
The PR's requested guarantee is therefore already present on main, with broader nested-plugin handling. |
What does this PR do?
Related Issue
N/A
Type of Change
Changes Made
How to Test
pytest tests/ -q— all tests should passChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture and workflows — or N/A