fix(skills): handle bytes in bundle content hash - #13531
Closed
zhao0112 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Related to #3751 (open) — same bytes-in-bundle-hash fix. Maintainers should pick one. |
1 similar comment
Collaborator
|
Related to #3751 (open) — same bytes-in-bundle-hash fix. Maintainers should pick one. |
This was referenced Apr 22, 2026
This was referenced May 3, 2026
This was referenced May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bytesentries inbundle_content_hash()without calling.encode()bytesandstrbundle contentFixes #13408
Root Cause
bundle_content_hash()assumed everybundle.files[...]value was astrand always called.encode("utf-8").SkillBundle.filesis already typed asDict[str, Union[str, bytes]], so any bundle containing rawbyteswould crash duringhermes skills updatewithAttributeError.Validation
/Users/zzl/.hermes/hermes-agent-update-20260421/venv/bin/python -m pytest -o addopts= tests/tools/test_skills_hub.py -q/Users/zzl/.hermes/hermes-agent-update-20260421/venv/bin/python -m py_compile tools/skills_hub.py tests/tools/test_skills_hub.pygit diff --check