Skip to content

fix(skills): handle bytes in bundle update hash - #19145

Closed
rylena wants to merge 1 commit into
NousResearch:mainfrom
rylena:fix/issue-19090-skill-bundle-hash
Closed

fix(skills): handle bytes in bundle update hash#19145
rylena wants to merge 1 commit into
NousResearch:mainfrom
rylena:fix/issue-19090-skill-bundle-hash

Conversation

@rylena

@rylena rylena commented May 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • handle SkillBundle.files entries that are already bytes in bundle_content_hash()
  • add regression coverage for byte-backed bundle files so skill update checks stop crashing

Verification

  • scripts/run_tests.sh tests/tools/test_skills_hub.py -k 'bundle_content_hash or check_for_skill_updates'
  • scripts/run_tests.sh tests/tools/test_skills_hub.py
  • independent delegated code review: passed

Closes #19090
Related to #19073

@alt-glitch alt-glitch added type/bug Something isn't working tool/skills Skills system (list, view, manage) P2 Medium — degraded but workaround exists labels May 3, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #13531, #3751, #2740, and #19081 — same one-line isinstance fix for bytes in bundle_content_hash(). Please consolidate.

@teknium1

teknium1 commented May 4, 2026

Copy link
Copy Markdown
Contributor

The same bytes fix landed via #19575 (salvage of @teknium1's #19328, which was itself the canonical consolidation of five concurrent PRs — including yours). The logic you proposed is identical; thanks for catching and fixing this bug. Both contributors who implemented the same fix get credit via the commit's AUTHOR_MAP and this acknowledgement. Closing as duplicate.

@teknium1 teknium1 closed this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Medium — degraded but workaround exists tool/skills Skills system (list, view, manage) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: hermes skills check/update crashes with AttributeError in bundle_content_hash

3 participants