fix(skills): hash bytes bundle contents - #19116
Closed
helix4u wants to merge 1 commit into
Closed
Conversation
Collaborator
1 similar comment
Collaborator
Contributor
Author
|
well fun. my search didn't find any of those. i'll just close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the skills hub update/check crash when fetched skill bundle file contents are bytes instead of strings.
SkillBundle.files is typed to allow str | bytes, and some source adapters intentionally populate bytes for bundled assets. bundle_content_hash() only handled strings, so update checks could crash with AttributeError: bytes object has no attribute encode.
Changes
Validation
Full-suite failing tests observed:
Fixes #13408