Skip to content

[BugFix] Fix Honcho HOME-aware config fallback - #13320

Closed
HiddenPuppy wants to merge 1 commit into
NousResearch:mainfrom
HiddenPuppy:codex/fix-13283-honcho-home
Closed

[BugFix] Fix Honcho HOME-aware config fallback#13320
HiddenPuppy wants to merge 1 commit into
NousResearch:mainfrom
HiddenPuppy:codex/fix-13283-honcho-home

Conversation

@HiddenPuppy

Copy link
Copy Markdown
Contributor

Fixes #13283

Summary

  • compute the shared ~/.honcho/config.json fallback from the current HOME at call time
  • add regression coverage for HOME changes after import
  • keep the existing Hermes-local and default-profile lookup order unchanged

Root Cause

GLOBAL_CONFIG_PATH captured Path.home() at import time, so later HOME overrides used by tests and isolated instances could still fall back to the original user's ~/.honcho/config.json.

Testing

  • source venv/bin/activate && python -m pytest tests/honcho_plugin/test_client.py -q
  • source venv/bin/activate && python -m pytest tests/hermes_cli/test_profiles.py -q
  • source venv/bin/activate && python -m pytest tests/ -q (fails in unrelated ACP/approval/browser/media/vision areas and missing optional extras in this checkout)

@HiddenPuppy HiddenPuppy changed the title [codex] Fix Honcho HOME-aware config fallback [BugFix] Fix Honcho HOME-aware config fallback Apr 21, 2026
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists area/config Config system, migrations, profiles labels Apr 22, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #13323 — same root cause (Honcho GLOBAL_CONFIG_PATH frozen at import time). Both fix #13283.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused fix. This is an automated hermes-sweeper review: the PR's exact behavior and regression coverage are already on current main.

  • 5d36871d923ce02bc22af487dae566ce1ea5e7f7 (“Fix Honcho HOME-aware global config fallback”) preserved this change with contributor authorship.
  • plugins/memory/honcho/client.py:75-99 resolves the global ~/.honcho/config.json fallback through Path.home() at call time, after the existing Hermes-local and default-profile checks.
  • tests/honcho_plugin/test_client.py:384-393 covers the patched-HOME fallback path.
  • The fix is contained in release v2026.4.30.

@teknium1 teknium1 closed this Jul 12, 2026
@teknium1 teknium1 added sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users labels Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Honcho client freezes ~/.honcho/config.json path at import time and ignores runtime HOME changes

3 participants