fix(honcho): HOME-aware global config fallback path resolution - #15359
Closed
erosika wants to merge 1 commit into
Closed
fix(honcho): HOME-aware global config fallback path resolution#15359erosika wants to merge 1 commit into
erosika wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #15381 (consolidated). |
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts #13320 by @HiddenPuppy with original authorship preserved.
Fixes #13283.
GLOBAL_CONFIG_PATHwas resolved once at import time asPath.home() / ".honcho" / "config.json". IfHOMEchanges mid-process (profile switching, test fixtures usingpatch.object(Path, "home", ...)), the fallback read the cached import-time value instead of the current HOME.Replaces the module-level constant with
resolve_global_config_path()that computes the path at call time.228/228 honcho_plugin tests pass locally.