Skip to content

fix(honcho): resolve global config path at runtime - #13323

Closed
sgaofen wants to merge 1 commit into
NousResearch:mainfrom
sgaofen:codex/fix-13283-honcho-runtime-home
Closed

fix(honcho): resolve global config path at runtime#13323
sgaofen wants to merge 1 commit into
NousResearch:mainfrom
sgaofen:codex/fix-13283-honcho-runtime-home

Conversation

@sgaofen

@sgaofen sgaofen commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Root Cause

GLOBAL_CONFIG_PATH was computed during module import, so tests or runtime environments that changed HOME later still fell back to the old home directory.

Tests

  • uv run --frozen --python 3.11 --extra dev pytest -o addopts='' tests/honcho_plugin/test_client.py -q (70 passed, 3 skipped)
  • git diff --check -- plugins/memory/honcho/client.py tests/honcho_plugin/test_client.py

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/plugins Plugin system and bundled plugins tool/memory Memory tool and memory providers labels Apr 22, 2026
@Bartok9

Bartok9 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Re-verified against current origin/main (27c486e3b): this appears resolved. resolve_config_path() in plugins/memory/honcho/client.py no longer returns a module-level GLOBAL_CONFIG_PATH constant — it now ends in return resolve_global_config_path(), and resolve_global_config_path() computes Path.home() / ".honcho" / "config.json" at call time. So the global path is resolved at runtime (honoring a changed $HOME / HERMES_HOME), which is what this PR set out to fix.

Recommend closing as superseded — happy to be corrected if I've misread the current state.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused regression fix. This automated hermes-sweeper review found that the requested behavior is already on current main.

  • plugins/memory/honcho/client.py:75-99 now computes ~/.honcho/config.json through resolve_global_config_path() at call time and uses it from resolve_config_path().
  • tests/honcho_plugin/test_client.py:384-393 covers the patched-Path.home() runtime fallback.
  • The implementation landed in 5d36871d923ce02bc22af487dae566ce1ea5e7f7 (Fix Honcho HOME-aware global config fallback) and shipped in v2026.4.30.
  • This matches the later verification from @Bartok9 and resolves the behavior reported in Bug: Honcho client freezes ~/.honcho/config.json path at import time and ignores runtime HOME changes #13283.

@teknium1 teknium1 closed this Jul 12, 2026
@teknium1 teknium1 added sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users labels Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P2 Medium — degraded but workaround exists sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades tool/memory Memory tool and memory providers type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Honcho client freezes ~/.honcho/config.json path at import time and ignores runtime HOME changes

4 participants