You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Observed Banger Ledger coder and raven worker sessions repeatedly send heartbeat=60 with foreground terminal calls; terminal correctly rejects this background-only argument, and runs timed out without accepted artifacts. Add worker-only guidance to omit notify/heartbeat on foreground calls, correct invalid arguments once, and never reroute a security denial. Regression covers prompt guidance and handler contract. Tests: 55 passed, 2 skipped (prompt builder + process heartbeat). No runtime activation or review verdict claimed. Rollback: revert 162e464.
Independent exact-head check on 162e464893aafac3adaa8cc3e41e2b105f77529b: I mirrored this patch in kvnloo#198 and ran the kanban worker prompt regression.
focused patched case: 1 passed
full test_prompt_builder.py: 55 passed
negative control: 1 failed
restored: focused case + full file green
This confirms the worker guidance now distinguishes foreground terminal calls from background=true calls that may use notify / heartbeat.
Heads-up: #133793 lands this class at the dispatcher instead — a foreground terminal call that carries a positive heartbeat runs once with the heartbeat dropped (cherry-pick of #119201 with authorship kept, plus the test/schema follow-up), while a foreground notify=true stays refused. Live repro in that PR body uses the exact argument shapes recorded from 173 production refusals this week. If it merges, this PR becomes unnecessary and will be closed as superseded with credit; leaving it open until then.
Superseded by #133793 (landed as cb6ffe6): a foreground terminal call that carries heartbeat now runs instead of being refused, so kanban workers no longer need a prompt-side workaround. Thanks @brownser for tracking this down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/agentCore agent runtime: loop, agent_init, prompt builder, context-compression, responses endpointcomp/cronCron scheduler and job managementneeds-decisionAwaiting maintainer decision before any implementationP3Low — cosmetic, nice to havesweeper:risk-cachingSweeper risk: may break/degrade prompt caching or cache-key stability (invariant)tool/terminalTerminal execution and process managementtype/bugSomething isn't working
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed Banger Ledger coder and raven worker sessions repeatedly send heartbeat=60 with foreground terminal calls; terminal correctly rejects this background-only argument, and runs timed out without accepted artifacts. Add worker-only guidance to omit notify/heartbeat on foreground calls, correct invalid arguments once, and never reroute a security denial. Regression covers prompt guidance and handler contract. Tests: 55 passed, 2 skipped (prompt builder + process heartbeat). No runtime activation or review verdict claimed. Rollback: revert 162e464.