Repository navigation
Conversation
…heartbeat call The refusal for background-only arguments on a foreground terminal call was generic and led with `background=true`. Models re-sent the identical call (8x retry loops reported on NousResearch#119196) or moved short commands into the background and flooded completion notices. 4317ed0 stopped schema-materialized providers from sending heartbeat=60, but callers that still send it explicitly hit the same loop (NousResearch#125303 shows kanban workers doing this). The refusal is kept, as intended. It now names the exact offending arguments as sent (`heartbeat=60`), says the command did not run, and puts the foreground retry (same call without those args) before the background option. Closes NousResearch#121634
Collaborator
|
Heads-up: #133793 lands this class at the dispatcher instead — a foreground |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…heartbeat call
The refusal for background-only arguments on a foreground terminal call was generic and led with
background=true. Models re-sent the identical call (8x retry loops reported on #119196) or moved short commands into the background and flooded completion notices. 4317ed0 stopped schema-materialized providers from sending heartbeat=60, but callers that still send it explicitly hit the same loop (#125303 shows kanban workers doing this).The refusal is kept, as intended. It now names the exact offending arguments as sent (
heartbeat=60), says the command did not run, and puts the foreground retry (same call without those args) before the background option.Closes #121634
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs