fix(kanban): teach workers valid foreground terminal calls

[kvnloo]

Tip leaf (fork-only diversify) — CLEAN

Closes #197

Maps origin tip NousResearch#125303 (not touched / not promoted).

What

Teach kanban workers that foreground terminal calls must omit notify/heartbeat (those apply only to background=true), and never repeat an unchanged rejected call.

Proof (fail→pass)

• GREEN: tip product + tip tests → 1 passed (test_kanban_worker_terminal_envelope_guidance); full test_prompt_builder.py 55 passed
• NEG: base product + tip tests → 1 failed (missing foreground envelope guidance in KANBAN_GUIDANCE)
• RESTORE: tip product restored → 1 passed; full file 55 passed

Notes

• github_writes_origin=0 — kvnloo fork only
• Codex promote: parked
• Tip SHA (origin): 162e464893aa
• Fork tip SHA: 1b3b8fa72bde02ae0a99e8cd0fe3dd290c92e5d1

Credit / provenance

• @brownser authored upstream NousResearch/hermes-agent#125303; this downstream candidate mirrors/tests that work rather than claiming its underlying fix as new authorship.

[github-actions]

૮ >ﻌ< ა ci review

_{running on 1b3b8fa — fix(kanban): teach workers valid foreground terminal calls}

---

_{Still running 17 jobs: Desktop core E2E / Desktop core E2E (Linux), Desktop update E2E / Desktop install/update E2E (Linux, app-update), Desktop update E2E / Desktop install/update E2E (Linux, build-fail), Desktop update E2E / Desktop install/update E2E (Linux, first-run), Desktop update E2E / Desktop install/update E2E (Linux, update-concurrency), OS-specific tests / Windows E2E (real processes), OS-specific tests / Windows install + update E2E / Windows install.ps1 + hermes update E2E, OS-specific tests / Windows-only tests, OS-specific tests / Windows-only tests (arm64), Python tests / Run tests, Python tests / e2e, Python tests / e2e-upgrade (core), Python tests / e2e-upgrade (git), Python tests / e2e-upgrade (handoff), Python tests / e2e-upgrade (hosts), Python tests / e2e-upgrade (network), Python tests / e2e-upgrade (pm)}

❌ Job failures

Check contributors / check-attribution · View job

Job Check contributors / check-attribution failed.

---

⚠️ Action required

Unmapped contributor email(s) · View job

New contributor email(s) are not in AUTHOR_MAP.

kvnloo@users.noreply.github.com (Kevin Rajan)

How to fix:

Run from the PR branch:

python3 scripts/audit_pr_attribution.py --fix
git add contributors && git commit -m "chore: map contributor emails" && git push

Or map one email manually (do NOT edit AUTHOR_MAP in scripts/releases/authors_legacy.py):

python3 scripts/add_contributor.py <email> <github-username>

To find the GitHub username for an email:

gh api 'search/users?q=EMAIL+in:email' --jq '.items[0].login'

[kvnloo]

Promoted the independent exact-head validation upstream: NousResearch#125303 (comment)

Keep this fork PR as durable evidence until origin disposition.