Skip to content

fix(gateway): preserve explicit delivery target ids - #11962

Closed
alexzhu0 wants to merge 1 commit into
NousResearch:mainfrom
alexzhu0:fix/delivery-target-parse-explicit-ids
Closed

fix(gateway): preserve explicit delivery target ids#11962
alexzhu0 wants to merge 1 commit into
NousResearch:mainfrom
alexzhu0:fix/delivery-target-parse-explicit-ids

Conversation

@alexzhu0

Copy link
Copy Markdown
Contributor

Summary

  • preserve explicit delivery target chat IDs verbatim instead of lowercasing the whole target string
  • avoid splitting Matrix room IDs into chat_id + thread_id just because the room ID contains :
  • add regression coverage for Slack case-sensitive IDs and Matrix room IDs

Verification

  • source venv/bin/activate && pytest -q tests/gateway/test_delivery.py

Closes #11768

@alexzhu0

Copy link
Copy Markdown
Contributor Author

Heads-up: #11893 (by @nightq) targets the same issue (#11768) with a different approach (case-sensitive chat-id preservation in DeliveryTarget.parse). The two diffs are not equivalent — ours focuses on explicit-id round-tripping, theirs on case handling. Fine to close this in favour of #11893 if you pick that direction; otherwise the fixes may be complementary.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/gateway Gateway runner, session dispatch, delivery labels Apr 24, 2026
@alexzhu0

Copy link
Copy Markdown
Contributor Author

Closing as part of post-mortem cleanup of an early-batch sweep that did not get review traction. Patch still applies cleanly to current main, and issue #11768 remains open (competitor #11893 was closed without merge) — feel free to repurpose if useful. My contribution methodology has moved to alexzhu0/echo-agent.

@alexzhu0 alexzhu0 closed this May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(gateway): DeliveryTarget.parse corrupts explicit chat IDs and Matrix room targets

2 participants