fix(gateway): preserve case-sensitive chat IDs in DeliveryTarget.parse - #11893
Closed
nightq wants to merge 1 commit into
Closed
fix(gateway): preserve case-sensitive chat IDs in DeliveryTarget.parse#11893nightq wants to merge 1 commit into
nightq wants to merge 1 commit into
Conversation
Fixes NousResearch#11768 Root cause: target.strip().lower() was lowercasing the entire target string, corrupting case-sensitive chat IDs like Slack C123ABC and Matrix !RoomABC. Fix: Only lowercase the platform prefix for case-insensitive matching; preserve the original case for chat_id and thread_id values.
alt-glitch
added
type/bug
Collaborator
|
Merged via PR #18553. Your commit was cherry-picked onto current main with your authorship preserved (rebase merge). Thanks for the contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #11768 where
DeliveryTarget.parse()was lowercasing the entire target string, corrupting case-sensitive chat IDs like SlackC123ABC.Root Cause
The original code used
target.strip().lower()on the entire target string before splitting. This caused:C123ABCto becomec123abc(Slack IDs are case-sensitive)Fix
chat_idandthread_idvaluesTELEGRAM,Telegram,telegramall work)Test Plan
Closes #11768