fix(gateway): preserve explicit delivery target IDs in delivery parsing - #10735
Closed
Junass1 wants to merge 1 commit into
Closed
fix(gateway): preserve explicit delivery target IDs in delivery parsing#10735Junass1 wants to merge 1 commit into
Junass1 wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the contribution, @Junass1! Closing this as a duplicate of #11962 (by @alexzhu0), which targets the same fix/feature. We're consolidating on that PR for review. If you want to help push it over the line, please jump in there — or if you think your approach is better for a specific reason that isn't covered in the other PR, let us know and we can reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes
DeliveryTarget.parse()so explicit delivery targets preserve the original ID payload instead of lowercasing and mis-splitting it.Before this change:
slack:C123ABCwas parsed aschat_id="c123abc"matrix:!RoomABC:example.orgwas parsed aschat_id="!roomabc"andthread_id="example.org"matrix:@Alice:example.orgwas parsed the same lossy wayAfter this change:
telegram:12345:678still worksWhy
DeliveryTarget.parse()was lowercasing the entire target string and then usingsplit(":", 2)for every platform. That works for simple numeric targets, but it breaks::, especially Matrix room/user IDsThis is a small gateway bugfix with direct impact on cron delivery and explicit cross-platform routing.
Changes
gateway/delivery.pyto normalize only the platform segment!room:serverand@user:servertargets as fullchat_idvalues instead of interpreting the homeserver colon as a thread separatortests/gateway/test_delivery.pyTests
Passed:
python -m pytest tests/gateway/test_delivery.py -qpython -m pytest tests/gateway/ -k delivery -q