fix(gateway/slack): batch salvage — reserved commands, session isolation, delivery fixes - #18553
Merged
Conversation
Slack has built-in slash commands (e.g. /status, /me, /join) that apps cannot register. When running `hermes slack manifest --write`, the generated manifest included /status, causing Slack to reject the entire manifest with a reserved-command error. Add _SLACK_RESERVED_COMMANDS frozenset of all known Slack built-ins and skip them in slack_native_slashes(). Affected commands remain reachable via /hermes <command>. Tests updated: - New test_excludes_slack_reserved_commands validates no leaks - test_includes_canonical_commands no longer asserts /status - test_telegram_parity accounts for expected Slack-only exclusions
YAML loads a bare numeric value such as
discord:
free_response_channels: 1491973769726791812
as an int. _discord_free_response_channels() / _slack_free_response_channels()
checked `isinstance(raw, list)` and `isinstance(raw, str)` in that order and
then fell through to `return set()`, so a single-channel config that happened
to be unquoted was silently dropped with no log line — the bot kept demanding
@mentions even though the channel was configured to free-response.
A multi-channel value like `1234567890,9876543210` does not trip this because
the comma forces YAML to parse it as a string. Single-channel configs are
the only case that breaks, which is exactly the footgun that's hardest to
diagnose (the config "looks right" and the feature just doesn't activate).
Note that the old-schema env-var bridge at gateway/config.py:614+ already
runs `str(frc)` when forwarding to SLACK_/DISCORD_FREE_RESPONSE_CHANNELS,
so the env-var fallback worked. The bug only surfaces on the
`config.extra["free_response_channels"]` path populated by the `platforms:`
bridge at gateway/config.py:576, which passes the raw YAML value through
unchanged.
Fix at the reader: treat any non-list value as a scalar, coerce with str(),
then apply the same CSV split semantics. This keeps the public contract
stable (list or str-like continues to work identically) while accepting
the ints that the YAML loader is free to hand us.
Added tests for both Discord and Slack covering:
- bare int value in config.extra
- list of ints in config.extra
Fixes #11768 Root cause: target.strip().lower() was lowercasing the entire target string, corrupting case-sensitive chat IDs like Slack C123ABC and Matrix !RoomABC. Fix: Only lowercase the platform prefix for case-insensitive matching; preserve the original case for chat_id and thread_id values.
This was referenced May 1, 2026
alt-glitch
added
type/bug
3 tasks
briandevans
added a commit
to briandevans/hermes-agent
that referenced
this pull request
May 30, 2026
…hats
A single Slack channel / DM can host multiple Assistant threads at the
same time (overlapping user requests, parallel sessions, etc.). The
typing-indicator tracker was keyed by chat_id alone:
self._active_status_threads: Dict[str, str] = {}
so the second concurrent `send_typing` for the same chat overwrote the
first thread's `thread_ts`. When the earlier thread's send finished,
`stop_typing` popped the wrong (newer) `thread_ts` — and the older
thread stayed stuck in "is thinking…" forever, as reported in NousResearch#24117.
The existing fix landed via NousResearch#18553 (April 22) covered the single-thread
lifecycle (set status on send_typing, clear on send / edit-finalize).
This PR extends that lifecycle to concurrent threads:
- Track per-thread instead of per-chat: `Dict[str, set[str]]`.
- `send_typing` adds the thread_ts to the chat's set (bounded at 128
active threads per chat as a defensive guard against missed clears).
- `stop_typing(chat_id, metadata={"thread_ts": ts})` clears that
specific thread. Without metadata, every tracked thread in the chat
is cleared (preserves the legacy base.py wiring that has no thread
context).
- `send()` finalize now passes its own `thread_ts` to `stop_typing` so
it clears only its own thread among concurrent ones.
- `send()` exception path now also clears the thread's status, so a
failed Slack post doesn't leave the user staring at "is thinking…".
- `edit_message(finalize=True)` keeps its existing behavior (clears
whatever's tracked for the chat — it has no thread context to
target a specific thread).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch salvage of 5 focused Slack bug fixes from open community PRs. Each fix is a clean cherry-pick with original authorship preserved; no modifications needed.
Salvaged PRs
/status,/me,/join, etc.) included in the native slash manifest cause Slack API registration failuresfree_response_channels: 1234567890loaded asintsilently returns empty set —isinstance(raw, str)gate rejects itDeliveryTarget.parse()calls.lower()on the entire target string including Slack channel IDs (C0ABC123) which are case-sensitivechat_type="dm"for all channels — users in shared channels share one agent session (session collision)stop_typing()call insend()/edit_message()Changes by file
hermes_cli/commands.py_SLACK_RESERVED_COMMANDSfrozenset + filter in_add()to skip 19 reserved Slack built-insgateway/platforms/slack.pystop_typing()after final send/editgateway/platforms/discord.pygateway/delivery.pyscripts/release.pytests/PRs closed as redundant (in follow-up comments)
/status→/status1(worse UX vs clean exclusion)Test plan
.pyfiles passpy_compile