Add splitTestsCompilation solidity setting (9): node:test updates#8136
Conversation
|
There was a problem hiding this comment.
Pull request overview
Updates the Hardhat Node Test Runner plugin to align its build task invocation with the new Solidity splitTestsCompilation setting, and adds regression tests to ensure the correct noTests flag behavior.
Changes:
- Passes
noTeststo thebuildtask based onhre.config.solidity.splitTestsCompilation. - Adds
node:testcoverage verifyingbuildinvocation arguments for split vs unified compilation modes. - Adds a test ensuring compilation is skipped when
noCompileis set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/hardhat-node-test-runner/test/index.ts | Adds tests that capture and assert build task args for different splitTestsCompilation and noCompile scenarios. |
| packages/hardhat-node-test-runner/src/task-action.ts | Changes the build invocation to derive noTests from solidity.splitTestsCompilation instead of always forcing noTests: true. |
|
Please ignore the spellcheck failure. The spec file will be deleted before merging. |
9f86311 to
ab9a3ad
Compare
fa67bed to
4468e58
Compare
ab9a3ad to
576a4f0
Compare
4468e58 to
c2e187e
Compare
576a4f0 to
bac7bca
Compare
c2e187e to
5105e8f
Compare
bac7bca to
7eec0b3
Compare
5105e8f to
50e26fe
Compare
7eec0b3 to
e6fee07
Compare
50e26fe to
31970e0
Compare
e6fee07 to
21066f3
Compare
31970e0 to
f0b9340
Compare
21066f3 to
d01afb9
Compare
f0b9340 to
546649a
Compare
d01afb9 to
3b1c1fc
Compare
546649a to
5e39826
Compare
5e39826 to
96b513c
Compare
2c24a0a to
c0f9741
Compare
cd1be43 to
6695e09
Compare
Just an update to how
buildis run