Skip to content

Add splitTestsCompilation solidity setting (9): node:test updates#8136

Merged
alcuadrado merged 2 commits intodont-split-compilationsfrom
dont-split-compilations-phase-9
Apr 16, 2026
Merged

Add splitTestsCompilation solidity setting (9): node:test updates#8136
alcuadrado merged 2 commits intodont-split-compilationsfrom
dont-split-compilations-phase-9

Conversation

@alcuadrado
Copy link
Copy Markdown
Member

Just an update to how build is run

@alcuadrado alcuadrado requested a review from Copilot April 12, 2026 22:13
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 12, 2026

⚠️ No Changeset found

Latest commit: 6695e09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Hardhat Node Test Runner plugin to align its build task invocation with the new Solidity splitTestsCompilation setting, and adds regression tests to ensure the correct noTests flag behavior.

Changes:

  • Passes noTests to the build task based on hre.config.solidity.splitTestsCompilation.
  • Adds node:test coverage verifying build invocation arguments for split vs unified compilation modes.
  • Adds a test ensuring compilation is skipped when noCompile is set.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/hardhat-node-test-runner/test/index.ts Adds tests that capture and assert build task args for different splitTestsCompilation and noCompile scenarios.
packages/hardhat-node-test-runner/src/task-action.ts Changes the build invocation to derive noTests from solidity.splitTestsCompilation instead of always forcing noTests: true.

@alcuadrado
Copy link
Copy Markdown
Member Author

Please ignore the spellcheck failure. The spec file will be deleted before merging.

@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-8 branch from 9f86311 to ab9a3ad Compare April 13, 2026 09:35
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from fa67bed to 4468e58 Compare April 13, 2026 09:35
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-8 branch from ab9a3ad to 576a4f0 Compare April 13, 2026 10:32
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from 4468e58 to c2e187e Compare April 13, 2026 10:32
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-8 branch from 576a4f0 to bac7bca Compare April 13, 2026 11:07
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from c2e187e to 5105e8f Compare April 13, 2026 11:07
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-8 branch from bac7bca to 7eec0b3 Compare April 13, 2026 11:21
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from 5105e8f to 50e26fe Compare April 13, 2026 11:21
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-8 branch from 7eec0b3 to e6fee07 Compare April 13, 2026 11:39
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from 50e26fe to 31970e0 Compare April 13, 2026 11:39
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-8 branch from e6fee07 to 21066f3 Compare April 13, 2026 12:06
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from 31970e0 to f0b9340 Compare April 13, 2026 12:06
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-8 branch from 21066f3 to d01afb9 Compare April 13, 2026 12:46
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from f0b9340 to 546649a Compare April 13, 2026 12:46
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-8 branch from d01afb9 to 3b1c1fc Compare April 13, 2026 16:28
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from 546649a to 5e39826 Compare April 13, 2026 16:28
@alcuadrado alcuadrado requested a review from Copilot April 13, 2026 16:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comment thread packages/hardhat-node-test-runner/test/index.ts Outdated
Comment thread packages/hardhat-node-test-runner/test/index.ts Outdated
Comment thread packages/hardhat-node-test-runner/test/index.ts Outdated
Comment thread packages/hardhat-node-test-runner/test/index.ts
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-8 branch from 2c24a0a to c0f9741 Compare April 13, 2026 19:38
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from cd1be43 to 6695e09 Compare April 13, 2026 19:38
@alcuadrado alcuadrado requested a review from Copilot April 13, 2026 19:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Base automatically changed from dont-split-compilations-phase-8 to dont-split-compilations April 16, 2026 16:37
@alcuadrado alcuadrado merged commit b61878e into dont-split-compilations Apr 16, 2026
45 checks passed
@alcuadrado alcuadrado deleted the dont-split-compilations-phase-9 branch April 16, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants