Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/hardhat-node-test-runner/src/task-action.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,8 @@ const testWithHardhat: NewTaskActionFunction<TestActionArguments> = async (
setGlobalOptionsAsEnvVariables(hre.globalOptions);

if (!noCompile) {
await hre.tasks.getTask("build").run({
noTests: true,
});
const noTests = hre.config.solidity.splitTestsCompilation;
await hre.tasks.getTask("build").run({ noTests });
console.log();
}

Expand Down
78 changes: 78 additions & 0 deletions packages/hardhat-node-test-runner/test/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@ import assert from "node:assert/strict";
import { describe, it } from "node:test";

import { useFixtureProject } from "@nomicfoundation/hardhat-test-utils";
import { overrideTask } from "hardhat/config";
import { createHardhatRuntimeEnvironment } from "hardhat/hre";

import HardhatNodeTestRunnerPlugin from "../src/index.js";

describe("Hardhat Node plugin", () => {
useFixtureProject("test-project");

Expand Down Expand Up @@ -44,4 +47,79 @@ describe("Hardhat Node plugin", () => {
process.env.NODE_ENV = nodeEnv;
}
});

describe("build invocation", () => {
function buildArgCaptor() {
const buildArgs: any[] = [];
const buildOverride = overrideTask("build")
.setAction(async () => {
return {
default: (args: any) => {
buildArgs.push(args);
return { contractRootPaths: [], testRootPaths: [] };
},
};
})
.build();
return { buildArgs, buildOverride };
}

it("should call build without noTests when splitTestsCompilation is false", async () => {
const { buildArgs, buildOverride } = buildArgCaptor();
const hre = await createHardhatRuntimeEnvironment({
plugins: [HardhatNodeTestRunnerPlugin],
tasks: [buildOverride],
});

await hre.tasks.getTask(["test", "nodejs"]).run({});

assert.equal(buildArgs.length, 1);
assert.equal(buildArgs[0].noTests, false);
});

it("should call build with noTests when splitTestsCompilation is true", async () => {
const { buildArgs, buildOverride } = buildArgCaptor();
const hre = await createHardhatRuntimeEnvironment({
solidity: {
version: "0.8.28",
splitTestsCompilation: true,
},
plugins: [HardhatNodeTestRunnerPlugin],
tasks: [buildOverride],
});

await hre.tasks.getTask(["test", "nodejs"]).run({});

assert.equal(buildArgs.length, 1);
assert.equal(buildArgs[0].noTests, true);
});

it("should skip compilation when noCompile is true without splitTestsCompilation", async () => {
const { buildArgs, buildOverride } = buildArgCaptor();
const hre = await createHardhatRuntimeEnvironment({
plugins: [HardhatNodeTestRunnerPlugin],
tasks: [buildOverride],
});

await hre.tasks.getTask(["test", "nodejs"]).run({ noCompile: true });

assert.equal(buildArgs.length, 0);
});

it("should skip compilation when noCompile is true with splitTestsCompilation", async () => {
const { buildArgs, buildOverride } = buildArgCaptor();
const hre = await createHardhatRuntimeEnvironment({
solidity: {
version: "0.8.28",
splitTestsCompilation: true,
},
plugins: [HardhatNodeTestRunnerPlugin],
tasks: [buildOverride],
});

await hre.tasks.getTask(["test", "nodejs"]).run({ noCompile: true });

assert.equal(buildArgs.length, 0);
Comment thread
alcuadrado marked this conversation as resolved.
});
});
});
Loading