Conversation
🦋 Changeset detectedLatest commit: ee8bcbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zoeyTM
force-pushed
the
fix/tx-hash-bug-v3
branch
from
3b1227d to
7275da6
Compare
zoeyTM
force-pushed
the
fix/tx-hash-bug-v3
branch
from
517dbe0 to
e75f03d
Compare
zoeyTM
force-pushed
the
fix/tx-hash-bug-v3
branch
from
e75f03d to
8bad5d4
Compare
zoeyTM
force-pushed
the
fix/tx-hash-bug-v3
branch
3 times, most recently
from
03b6c6f to
469f251
Compare
kanej
reviewed
Apr 29, 2025
kanej
reviewed
Apr 29, 2025
kanej
reviewed
Apr 29, 2025
kanej
reviewed
Apr 29, 2025
kanej
reviewed
Apr 29, 2025
Member
kanej
left a comment
kanej
left a comment
There was a problem hiding this comment.
I have been through and done a comparison with the v2 PR. I left a few questions, but this is looking good.
Can I ask how I test this manually?
zoeyTM
force-pushed
the
fix/tx-hash-bug-v3
branch
3 times, most recently
from
dc81860 to
3f5f5b0
Compare
kanej
approved these changes
May 5, 2025
Member
kanej
left a comment
kanej
left a comment
There was a problem hiding this comment.
I have done a file by file comparison and it looks good. Lets get this merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported this bug fix from Ignition in Hardhat 2 to Hardhat 3.