Ignition: fix for bug when we fail to save transaction hash#6229
Ignition: fix for bug when we fail to save transaction hash#6229
Conversation
🦋 Changeset detectedLatest commit: 84a763e The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ac7b9dc to
476d1fe
Compare
d03bab5 to
84a763e
Compare
| // case 2: the user sent a different transaction that replaced ours | ||
| // so we check their transaction for the required number of confirmations | ||
| else { | ||
| return checkConfirmations( |
There was a problem hiding this comment.
I'm not sure if I understand this part, let's look at it on a call. Other than that LGTM.
There was a problem hiding this comment.
self-answer: This works because it's the else to the if in line 104. Hence, the transaction matches the sender and nonce, but not data and value. i.e. a replacement.
alcuadrado
left a comment
There was a problem hiding this comment.
Re-reviewed this, and now I get it. I think the else in the newline was confusing me.
In this PR
TRANSACTION_PREPARE_SENDthat is written to journal immediately before sending a transaction to the networktrack-txcommand to add it to the deploymenttrack-txcommand that allows users to add a missing transaction back to their deployment. accounts for several edge cases