Skip to content

libuv: disable test ipc_closed_handle#80341

Closed
arnoldfarkas wants to merge 1 commit intoNixOS:masterfrom
WorldQuant:wq_libuv
Closed

libuv: disable test ipc_closed_handle#80341
arnoldfarkas wants to merge 1 commit intoNixOS:masterfrom
WorldQuant:wq_libuv

Conversation

@arnoldfarkas
Copy link
Copy Markdown
Contributor

Motivation for this change

Disabling unstable test case in libuv: it often times out, depending on infrastructure.
See libuv/libuv#2307 for further information

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cstrahan February 17, 2020 09:23
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 17, 2020
@veprbl
Copy link
Copy Markdown
Member

veprbl commented Feb 17, 2020

This doesn't fail on Hydra and it's a mass-rebuild, so, please, target staging branch instead of master.

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Feb 21, 2020

🤔 this actually seems interesting: libuv/libuv#2679 – perhaps it would allow us to enable many of the tests in nixpkgs again, though that doesn't seem an important aim to me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants