libuv: disable test ipc_closed_handle#80341
Closed
arnoldfarkas wants to merge 1 commit intoNixOS:masterfrom
Closed
libuv: disable test ipc_closed_handle#80341arnoldfarkas wants to merge 1 commit intoNixOS:masterfrom
arnoldfarkas wants to merge 1 commit intoNixOS:masterfrom
Conversation
This was referenced Feb 17, 2020
Member
|
This doesn't fail on Hydra and it's a mass-rebuild, so, please, target staging branch instead of master. |
Member
|
🤔 this actually seems interesting: libuv/libuv#2679 – perhaps it would allow us to enable many of the tests in nixpkgs again, though that doesn't seem an important aim to me... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Disabling unstable test case in libuv: it often times out, depending on infrastructure.
See libuv/libuv#2307 for further information
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)