ectool: init at 4.9

[ghost]

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Notify maintainers

cc @

[worldofpeace]

@GrahamcOfBorg eval

[aanderse]

@GrahamcOfBorg build ectool

[aanderse]

I don't have anything to test this with, and I'm not familiar with coreboot... but LGTM 👍
@worldofpeace anything to add? It is @petabyteboy (read: quality 😄 ), so a merge is in order...?

EDIT: Somehow I did not notice arch64 failure... 😞 @petabyteboy want to take a look?

[worldofpeace]

How about?

makeFlags = [ 
  "PREFIX=${placeholder "out"}"
  "INSTALL=install"
];

preBuild = ''
  cd util/ectool
'';

Then I think you can drop the custom installPhase, though upstream should really be using DESTDIR too

https://github.com/coreboot/coreboot/blob/master/util/ectool/Makefile#L38

[ghost]

I would like to stick to the pattern used in all other coreboot util packages for now, and refactor or merge them later.

[worldofpeace]

Somehow I did not notice arch64 failure... 😞 @petabyteboy want to take a look?

I think the error,

ec.c:22:10: fatal error: sys/io.h: No such file or directory
 #include <sys/io.h>

typically means something needs porting. Didn't look at the source though.

[worldofpeace]

If in the future another package is added for coreboot utils, it would probably be best if there was a package that was just all of them.

[ghost]

Very valid point, I will look into it in the future.

[ghost]

• rebased
• updated to 4.10
• changed platforms to x86 only

[ghost]

Somehow I did not notice arch64 failure... disappointed @petabyteboy want to take a look?

I think the error,

ec.c:22:10: fatal error: sys/io.h: No such file or directory
 #include <sys/io.h>

typically means something needs porting. Didn't look at the source though.

From https://bugzilla.redhat.com/show_bug.cgi?id=1116162:

The sys/ headers are architecture and OS dependent. They do not exist across all targets and io.h in particular is intended for very lowl-level non-portable uses often in coordination with the kernel. The only targets that provide sys/io.h are x86*, Alpha, IA64, and 32-bit ARM. No other systems provide it.

So either way this has do be done in upstream glibc or coreboot.

[ghost]

I will replace this with a PR merging all coreboot util packages into one for easier maintenance in the future.

[ghost]

superseeded by #67836

[worldofpeace]

I will replace this with a PR merging all coreboot util packages into one for easier maintenance in the future.

That's great @petabyteboy ✨