Skip to content

ectool: init at 4.9 #66494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

ectool: init at 4.9 #66494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions pkgs/tools/misc/ectool/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{ stdenv, fetchurl }:

stdenv.mkDerivation rec {
pname = "ectool";
version = "4.10";

src = fetchurl {
url = "https://coreboot.org/releases/coreboot-${version}.tar.xz";
Copy link
Contributor

@worldofpeace worldofpeace Aug 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If in the future another package is added for coreboot utils, it would probably be best if there was a package that was just all of them.

Copy link
Author

@ghost ghost Aug 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very valid point, I will look into it in the future.

sha256 = "1jsiz17afi2lqg1jv6lsl8s05w7vr7iwgg86y2qp369hcz6kcwfa";
};

buildPhase = ''
make -C util/ectool
Copy link
Contributor

@worldofpeace worldofpeace Aug 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about?

makeFlags = [ 
  "PREFIX=${placeholder "out"}"
  "INSTALL=install"
];

preBuild = ''
  cd util/ectool
'';

Then I think you can drop the custom installPhase, though upstream should really be using DESTDIR too

https://github.com/coreboot/coreboot/blob/master/util/ectool/Makefile#L38

Copy link
Author

@ghost ghost Aug 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to stick to the pattern used in all other coreboot util packages for now, and refactor or merge them later.

'';

installPhase = ''
install -Dm755 util/ectool/ectool $out/bin/ectool
'';

meta = with stdenv.lib; {
description = "Dump the RAM of a laptop's Embedded/Environmental Controller (EC)";
homepage = "https://www.coreboot.org";
license = licenses.gpl2;
maintainers = [ maintainers.petabyteboy ];
platforms = [ "i686-linux" "x86_64-linux" ];
};
}

2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14979,6 +14979,8 @@ in

ifdtool = callPackage ../tools/misc/ifdtool { };

ectool = callPackage ../tools/misc/ectool { };

cbmem = callPackage ../tools/misc/cbmem { };

nvramtool = callPackage ../tools/misc/nvramtool { };
Expand Down