jetbrains.jdk: add darwin support#497855
Draft
Eveeifyeve wants to merge 4 commits intoNixOS:masterfrom
Draft
Conversation
13 tasks
Member
Author
|
This is the error is for darwin: |
NOTE: I have added a TODO to remove x86_64 darwin support, for more info please see NixOS#492160 about the deprecation.
This is needed for jetbrains jdk to pass the post fixup phase
NOTE: I have added a TODO to remove x86_64 darwin support, for more info please see NixOS#492160 about the deprecation.
NOTE: I have added a TODO to remove x86_64 darwin support, for more info please see NixOS#492160 about the deprecation.
b119d47 to
7389b2b
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds darwin support to jetbrains.jdk.
This is currently marked broken due to it not building on darwin due to fixup issue at jcef.
Closes: #398564
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.