Draft
Conversation
d40d6f3 to
cc966a6
Compare
Otherwise we end up evaluating into `i686-darwin` in CI…
f4bf79f to
8e29789
Compare
This was referenced Feb 19, 2026
8e29789 to
26c890b
Compare
x86_64-darwinx86_64-darwin
13 tasks
26c890b to
ec7a124
Compare
3b91f27 to
4559f12
Compare
13 tasks
23968c4 to
bec2fd8
Compare
The supported systems can differ across release branches. The original file is kept until the GitHub CI is migrated.
For consistency with `release.nix`.
We’ve never deprecated a platform in widespread use before, and it seems prudent to warn users about the upcoming end of support so they can plan appropriately. I tried to make this relatively unobtrusive by taking advantage of the import cache and offering a way to turn it off, but I anticipate there might still be issues with e.g. `nix shell nixpkgs#…` and spammy warnings from multiple instantiations of Nixpkgs. I’m not sure there’s much we can do about that unless we take a different strategy entirely; `nix shell --impure nixpkgs#…` with a `~/.config/nixpkgs/config.nix` is about the best UX we can hope to offer with the restrictions of flakes.
This will apply to the stable release branches too, but that seems unavoidable: we use `nixpkgs-unstable` in `ci/pinned.json`, which means that the development shell for stable release branches is based on the unstable branch. Once we drop support for a system on the unstable branch, it can no longer be used for Nixpkgs development on the next pin, even when targeting already‐released stable branches. Since Nixpkgs contributors would generally be expected to be less likely to be using deprecated platforms, and we usually operate with a backport workflow where changes target the unstable branch first, this is probably acceptable. A potential alternative would be to pin the stable branch for CI instead.
bec2fd8 to
306fb48
Compare
Eveeifyeve
added a commit
to DigitalBrewStudios/nixpkgs
that referenced
this pull request
Mar 8, 2026
NOTE: I have added a TODO to remove x86_64 darwin support, for more info please see NixOS#492160 about the deprecation.
Eveeifyeve
added a commit
to DigitalBrewStudios/nixpkgs
that referenced
this pull request
Mar 8, 2026
NOTE: I have added a TODO to remove x86_64 darwin support, for more info please see NixOS#492160 about the deprecation.
Eveeifyeve
added a commit
to DigitalBrewStudios/nixpkgs
that referenced
this pull request
Mar 8, 2026
NOTE: I have added a TODO to remove x86_64 darwin support, for more info please see NixOS#492160 about the deprecation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The follow‐up to #492100 (which this will appear to include, until that PR and its requirements are merged), for after branch‐off in a few months’ time. Just opening this as a draft to check against CI for now.
This depends on #492103 for Hydra, although that won’t show up in CI so I haven’t included it here.
I’ve kept this PR to just the initial breaking changes, release notes, and error handling; the tree after this PR is still formally incorrect in that there are still references to the removed
pkgsCross.x86_64-darwininpassthru.tests, update scripts that will break because of the platform no longer existing, etc., along with a ton of optional clean‐up left to do. I have a very large stack to address those, which I will push out incrementally, but it would be unreviewable if bundled all into one PR. I’ve pushed this branch to the main Nixpkgs repository so that I can stack those PRs on top of this one for easier review.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.