jetbrains.jdk(darwin): init at 21.0.4-b598.4; jetbrains.jcef(darwin): init at 867

[aoli-al]

This PR enables jetbrains.jdk on Darwins. This PR fixes: #84263

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
  • I used JetbrainRuntime to compile my intellj plugin: https://github.com/cmu-pasta/fray/blob/jetbrain-runtime-test/flake.nix
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[aoli-al]

Hi @leona-ya and @Infinidoge I saw you have reviewed this package recently. Could you please review my PR? Thanks!

[Henry-Hiles]

Is this jetbrains.jdk like the title says or jetbrains.sdk like the desc says? Or both, I'm not familiar with java tooling.

[Henry-Hiles]

To me, it looks like .jdk, but maybe I'm wrong.

[aoli-al]

sorry for the typo, it should be jdk

[Henry-Hiles]

Right, LGTM then, but can't test since I don't have a darwin machine. I recommend someone else tests before a merge, as the changes are fairly indepth.

[Henry-Hiles]

I'm also not sure if the title should be init, since this is, as far as I can tell, not a new package, it only is added on darwin with this PR. Not sure of convention for that.

[aoli-al]

Thanks! I wasn't sure about the title either, and I just followed the previous PR #152723

[Henry-Hiles]

Thanks! I wasn't sure about the title either, and I just followed the previous PR #152723

Ah, gotcha

[Infinidoge]

The commit in this PR should be split and retitled to better reflect the addition of darwin compatibility, as opposed to just a new version addition

[aoli-al]

I noticed that ofborg is blocked because of Xcode.

https://logs.ofborg.org/?attempt_id=b42eac3d-c58b-4efd-a630-a5c641b2ee18&key=nixos%2Fnixpkgs.398564

I just saw this and I'll try to use Apple SDK instead of the entire Xcode.

[aoli-al]

Ah, jdk depends on metal, which is only available in Xcode (#387516, #290808).

At least I can build jcef without requiring xcode. @Infinidoge can you please take a look?

[aoli-al]

Gentle ping @Infinidoge

Also, I'm fine being a maintainer of this package since I use it regularly.

[aoli-al]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 398564

---

aarch64-darwin

✅ 4 packages built:

• jetbrains.jcef
• jetbrains.jcef.unpacked
• jetbrains.jdk
• jetbrains.jdk-no-jcef

[Infinidoge]

Apologies for the delay. This week and next week have been/are quite busy for me as these are the final weeks of the semester, so it'll be a little while before I am able to do more complex reviews. If anyone else in @NixOS/java could take a look, I'd appreciate it.

[Eveeifyeve]

@aoli-al still working on this pr or am I okay to take this over?

[aoli-al]

@aoli-al still working on this pr or am I okay to take this over?

Yes, feel free to continue. I stop using MacOS and cannot really continue it but I'm happy to review if you can resolve conflicts.

[aoli-al]

Also we may want to merge #470840 first. That PR simplifies the jcef config a lot.