zlib: disable static output on windows#490607
Merged
wolfgangwalther merged 1 commit intoNixOS:staging-nextfrom Feb 17, 2026
Merged
zlib: disable static output on windows#490607wolfgangwalther merged 1 commit intoNixOS:staging-nextfrom
wolfgangwalther merged 1 commit intoNixOS:staging-nextfrom
Conversation
The install script ignores the configured libdir in case of windows. We could move it manually like it was done before <NixOS#476830> but even before that we did not move `libz.dll.a` so I think it makes sense to just disable this split on windows. Fixes: NixOS#476830 (comment) Signed-off-by: Marcin Serwin <marcin@serwin.dev>
This comment was marked as outdated.
This comment was marked as outdated.
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
13 tasks
1 task
13 tasks
Contributor
|
This fixes |
Merged
via the queue into
NixOS:staging-next
with commit Feb 17, 2026
b346aa4
32 of 34 checks passed
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The install script ignores the configured libdir in case of windows. We could move it manually like it was done before #476830 but even before that we did not move
libz.dll.aso I think it makes sense to just disable this split on windows.Fixes: #476830 (comment)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.