Skip to content

haskellPackages: fix some pkgsCross.ucrt64 packages#481185

Merged
wolfgangwalther merged 6 commits intoNixOS:haskell-updatesfrom
alexfmpe:haskell-ucrt64-fixes
Feb 17, 2026
Merged

haskellPackages: fix some pkgsCross.ucrt64 packages#481185
wolfgangwalther merged 6 commits intoNixOS:haskell-updatesfrom
alexfmpe:haskell-ucrt64-fixes

Conversation

@alexfmpe
Copy link
Copy Markdown
Member

@alexfmpe alexfmpe commented Jan 18, 2026 •
edited
Loading 

nix-build -E 'with (import ./. {}).haskellPackages; [ streaming-commons vector unix-time basement http-client crypton-x509-system ]'

nix-build -E 'with (import ./. {}).pkgsCross.ucrt64.haskell.packages.ghc912; [ streaming-commons vector unix-time basement http-client crypton-x509-system ]'

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

alexfmpe
alexfmpe commented Jan 18, 2026
View reviewed changes
pkgs/development/haskell-modules/configuration-common.nix
# vector-0.13.2.0 has a doctest < 0.24 constraint
jailbreak = true;
# inspection-testing doesn't work on all archs & ABIs
doCheck = !self.inspection-testing.meta.broken;
Copy link
Copy Markdown
Member Author

@alexfmpe alexfmpe Jan 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ended up overriding doCheck default value, which was probably not the intention.
In particular it would enable the test suite for vector even under cross, which fails to build if there's no TH support for the target

Copy link
Copy Markdown
Contributor

@wolfgangwalther wolfgangwalther Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have a helper function precisely because of this problem: dontCheckIf. May we should do vector = lib.pipe ... [ ] and use that.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Jan 18, 2026
@alexfmpe
Copy link
Copy Markdown
Member Author

alexfmpe commented Jan 18, 2026 •
edited
Loading

Yikes, mass rebuild. Likely coming from either vector, basement or crypton-x509-system. For the later 2, I applied the patch unconditionally, but it could also have gone on configuration-windows.nix.

wolfgangwalther
wolfgangwalther reviewed Jan 28, 2026
View reviewed changes
pkgs/development/haskell-modules/configuration-common.nix
# vector-0.13.2.0 has a doctest < 0.24 constraint
jailbreak = true;
# inspection-testing doesn't work on all archs & ABIs
doCheck = !self.inspection-testing.meta.broken;
Copy link
Copy Markdown
Contributor

@wolfgangwalther wolfgangwalther Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have a helper function precisely because of this problem: dontCheckIf. May we should do vector = lib.pipe ... [ ] and use that.

@wolfgangwalther
Copy link
Copy Markdown
Contributor

wolfgangwalther commented Jan 28, 2026

basement or crypton-x509-system

built these two on linux successfully.

Will build windows stuff later.

@wolfgangwalther
Copy link
Copy Markdown
Contributor

wolfgangwalther commented Jan 28, 2026

Windows builds confirmed as well.

@alexfmpe alexfmpe force-pushed the haskell-ucrt64-fixes branch from 1e0d028 to 412a716 Compare January 31, 2026 03:10
@alexfmpe alexfmpe mentioned this pull request Jan 31, 2026
Merged
13 tasks
wolfgangwalther
wolfgangwalther approved these changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure when to merge this due to the mass rebuild, did not look at the current state of haskell-updates.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 2, 2026
@alexfmpe alexfmpe force-pushed the haskell-ucrt64-fixes branch 2 times, most recently from f605251 to 531aa6e Compare February 14, 2026 21:57
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Feb 14, 2026
@alexfmpe
Copy link
Copy Markdown
Member Author

alexfmpe commented Feb 15, 2026

Needs #490607 for streaming-commons / http-client to actually build

@wolfgangwalther wolfgangwalther added this pull request to the merge queue Feb 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2026
@wolfgangwalther wolfgangwalther added this pull request to the merge queue Feb 17, 2026
@wolfgangwalther
Copy link
Copy Markdown
Contributor

wolfgangwalther commented Feb 17, 2026

(fixed eval on the target branch again)

Merged via the queue into NixOS:haskell-updates with commit fd7cd0e Feb 17, 2026
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexfmpe @wolfgangwalther