zlib: fix static library path in pkg-config module

[marcin-serwin]

Specify the correct paths for installation in configuration phase. This fixes the created pkg-config module and saves us from needing to move files manually into the desired outputs.

Fixes: #66461

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[doronbehar]

Changes LGTM, and I endorse this change.

[doronbehar]

I'm testing this change now, and will take a look at the files it produces. If everything looks fine to me, I will merge it.

[doronbehar]

Looks perfectly fine to me:

tree $(nix build --no-link --print-out-paths -Lf. zlib.{out,dev,static})

Prints:

/nix/store/na03q4r0gwnx39ipg3mf4vh48ywb2gjh-zlib-1.3.1
├── lib
│   ├── libz.so -> libz.so.1.3.1
│   ├── libz.so.1 -> libz.so.1.3.1
│   └── libz.so.1.3.1
└── share
    └── man
        └── man3
            └── zlib.3.gz
/nix/store/x1ahgp3wkj4542lmkijg6sdybpw2blk1-zlib-1.3.1-dev
├── include
│   ├── zconf.h
│   └── zlib.h
├── nix-support
│   └── propagated-build-inputs
└── share
    └── pkgconfig
        └── zlib.pc
/nix/store/ri4nl959pj4iys7d0k0q963a7ajwyac9-zlib-1.3.1-static
└── lib
    └── libz.a

12 directories, 9 files

And:

cat /nix/store/x1ahgp3wkj4542lmkijg6sdybpw2blk1-zlib-1.3.1-dev/share/pkgconfig/zlib.pc

Shows:

prefix=/nix/store/na03q4r0gwnx39ipg3mf4vh48ywb2gjh-zlib-1.3.1
exec_prefix=${prefix}
libdir=/nix/store/ri4nl959pj4iys7d0k0q963a7ajwyac9-zlib-1.3.1-static/lib
sharedlibdir=/nix/store/na03q4r0gwnx39ipg3mf4vh48ywb2gjh-zlib-1.3.1/lib
includedir=/nix/store/x1ahgp3wkj4542lmkijg6sdybpw2blk1-zlib-1.3.1-dev/include

Name: zlib
Description: zlib compression library
Version: 1.3.1

Requires:
Libs: -L${libdir} -L${sharedlibdir} -lz
Cflags: -I${includedir}

[alexfmpe]

This might have broken the build on windows - these both work on master and fail after this PR

nix-build -A pkgsCross.x86_64-cygwin.zlib
nix-build -A pkgsCross.ucrt64.zlib

with

shrinking RPATHs of ELF executables and libraries in /nix/store/mssliq64xv9p7hahrkc3lqzrfv09ij9p-zlib-x86_64-pc-cygwin-1.3.1
checking for references to /build/ in /nix/store/mssliq64xv9p7hahrkc3lqzrfv09ij9p-zlib-x86_64-pc-cygwin-1.3.1...
patching script interpreter paths in /nix/store/mssliq64xv9p7hahrkc3lqzrfv09ij9p-zlib-x86_64-pc-cygwin-1.3.1
shrinking RPATHs of ELF executables and libraries in /nix/store/x7zxybfvkcpag7lfij1c4f6yrsb3a7g1-zlib-x86_64-pc-cygwin-1.3.1-dev
checking for references to /build/ in /nix/store/x7zxybfvkcpag7lfij1c4f6yrsb3a7g1-zlib-x86_64-pc-cygwin-1.3.1-dev...
patching script interpreter paths in /nix/store/x7zxybfvkcpag7lfij1c4f6yrsb3a7g1-zlib-x86_64-pc-cygwin-1.3.1-dev
error: builder for '/nix/store/pv7dglxzgdp4622a5qm9rv7ikhbr0ayf-zlib-x86_64-pc-cygwin-1.3.1.drv' failed to produce output path for output 'static' at '/nix/store/pv7dglxzgdp4622a5qm9rv7ikhbr0ayf-zlib-x86_64-pc-cygwin-1.3.1.drv.chroot/root/nix/store/q55d3s1spnndcc1bpzfpmiv4qwykkn93-zlib-x86_64-pc-cygwin-1.3.1-static'