Skip to content

top-level/stage: assert no callPackage with by-name paths #489120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
qweered wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

top-level/stage: assert no callPackage with by-name paths #489120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pkgs/top-level/stage.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,23 @@ let
overlays
;
} res self super;
# Check for callPackage calls that reference by-name paths
allPackagesPath = toString ./all-packages.nix;
allPackagesLines = lib.splitString "\n" (builtins.readFile ./all-packages.nix);
callPackageByNameAttrs = lib.filter (
name:
let
pos = builtins.unsafeGetAttrPos name res;
isFromAllPackages = pos != null && pos.file == allPackagesPath;
lineContent = if isFromAllPackages then lib.elemAt allPackagesLines (pos.line - 1) else "";
usesCallPackage = lib.hasInfix "callPackage" lineContent;
callsByName = lib.hasInfix "by-name" lineContent;
in
isFromAllPackages && usesCallPackage && callsByName
) (lib.attrNames res);
in
assert lib.assertMsg (callPackageByNameAttrs == [ ])
"The following attributes in `pkgs/top-level/all-packages.nix` used `callPackage` with a `pkgs/by-name/` path. Use `<package>.override { }` instead: ${lib.concatStringsSep ", " callPackageByNameAttrs}";
res;

aliases = self: super: lib.optionalAttrs config.allowAliases (import ./aliases.nix lib self super);
Expand Down
Loading