Skip to content

gnome-{settings-daemon,shell,control-center}: fix duplicated sinks#487154

Closed
jian-lin wants to merge 1 commit intoNixOS:masterfrom
linj-fork:pr/gnome-duplicated-sink
Closed

gnome-{settings-daemon,shell,control-center}: fix duplicated sinks#487154
jian-lin wants to merge 1 commit intoNixOS:masterfrom
linj-fork:pr/gnome-duplicated-sink

Conversation

@jian-lin
Copy link
Contributor

@jian-lin jian-lin commented Feb 5, 2026

This cherry-picks a commit to fix libgnome-volume-control#39.

A follow-up of #482791

My systems have been running with this patch for a few days.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@jian-lin jian-lin requested a review from jtojnar February 5, 2026 07:52
This cherry-picks a commit to fix libgnome-volume-control#39.
@jian-lin jian-lin force-pushed the pr/gnome-duplicated-sink branch from f95eb8e to 1dee872 Compare February 5, 2026 07:54
@jian-lin jian-lin changed the title gnome-settings-daemon,gnome-shell: fix duplicated virtual sinks gnome-{settings-daemon,shell,control-center}: fix duplicated sinks Feb 5, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Feb 5, 2026
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 7, 2026
Comment on lines +123 to +131

# fix https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/issues/39
(fetchpatch {
name = "fix-duplicated-virtual-sinks.patch";
url = "https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/commit/3e68238ed7c9d3f26f8bfaf03780f79ce7c7043e.patch";
hash = "sha256-miOtI0Y/dUCLtTU5Wckp34k1JEJ87wyoDWAt8Cc1BOI=";
stripLen = 1;
extraPrefix = "subprojects/gvc/";
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is included in #490335 so this can be removed.

I'll test if the other 2 patches are needed when #490335 reaches nixos-unstable.

Mark this PR as draft for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems not needed after #490335. Closing.

@jian-lin jian-lin marked this pull request as draft February 14, 2026 16:15
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 14, 2026
@jian-lin jian-lin closed this Feb 21, 2026
@jian-lin jian-lin deleted the pr/gnome-duplicated-sink branch February 21, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants