Skip to content

gnome-{settings-daemon,shell,control-center}: fix duplicated sinks #487154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jian-lin wants to merge 1 commit into from
Closed

gnome-{settings-daemon,shell,control-center}: fix duplicated sinks #487154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkgs/by-name/gn/gnome-control-center/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
lib,
stdenv,
replaceVars,
fetchpatch,
accountsservice,
adwaita-icon-theme,
blueprint-compiler,
Expand Down Expand Up @@ -89,6 +90,15 @@ stdenv.mkDerivation (finalAttrs: {
inherit glibc tzdata shadow;
inherit cups networkmanagerapplet;
})

# fix https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/issues/39
(fetchpatch {
name = "fix-duplicated-virtual-sinks.patch";
url = "https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/commit/3e68238ed7c9d3f26f8bfaf03780f79ce7c7043e.patch";
hash = "sha256-miOtI0Y/dUCLtTU5Wckp34k1JEJ87wyoDWAt8Cc1BOI=";
stripLen = 1;
extraPrefix = "subprojects/gvc/";
})
];

nativeBuildInputs = [
Expand Down
9 changes: 9 additions & 0 deletions pkgs/by-name/gn/gnome-settings-daemon/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,15 @@ stdenv.mkDerivation (finalAttrs: {
stripLen = 1;
extraPrefix = "subprojects/gvc/";
})

# fix https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/issues/39
(fetchpatch {
name = "fix-duplicated-virtual-sinks.patch";
url = "https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/commit/3e68238ed7c9d3f26f8bfaf03780f79ce7c7043e.patch";
hash = "sha256-miOtI0Y/dUCLtTU5Wckp34k1JEJ87wyoDWAt8Cc1BOI=";
stripLen = 1;
extraPrefix = "subprojects/gvc/";
})
];

depsBuildBuild = [
Expand Down
9 changes: 9 additions & 0 deletions pkgs/by-name/gn/gnome-shell/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,15 @@ stdenv.mkDerivation (finalAttrs: {
stripLen = 1;
extraPrefix = "subprojects/gvc/";
})

# fix https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/issues/39
(fetchpatch {
name = "fix-duplicated-virtual-sinks.patch";
url = "https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/commit/3e68238ed7c9d3f26f8bfaf03780f79ce7c7043e.patch";
hash = "sha256-miOtI0Y/dUCLtTU5Wckp34k1JEJ87wyoDWAt8Cc1BOI=";
stripLen = 1;
extraPrefix = "subprojects/gvc/";
})
Comment on lines +123 to +131
Copy link
Contributor Author

@jian-lin jian-lin Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is included in #490335 so this can be removed.

I'll test if the other 2 patches are needed when #490335 reaches nixos-unstable.

Mark this PR as draft for now.

Copy link
Contributor Author

@jian-lin jian-lin Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems not needed after #490335. Closing.

];

nativeBuildInputs = [
Expand Down
Loading