gnome-{settings-daemon,control-center,shell}: fix crash with hands-free profile

[limwa]

Applies https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/merge_requests/31 to all projects that depend on libgnome-volume-control.

Fixes #475202.

Alternative to #482761.

Fixes a crash in GNOME when a user switches to a hands-free bluetooth profile.

Note: All commits are bundled into a single PR to ensure that the behavior is consistent across all packages. Extracting each commit to a different PR could lead users to have some of the packages with the unpatched version and the other packages with the patched version.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[limwa]

This PR won't build anymore because the PR patch changed. I'll update the hash soon. Also, the upstream PR was merged.

[jtojnar]

Why not continue to fetchpatch now that the MR is merged?

[limwa]

Why not continue to fetchpatch now that the MR is merged?

I got a bit confused as to how that would work. I've reverted to use fetchpatch and I've also updated the hashes.

[SuperSandro2000]

LGTM

[SuperSandroBot]

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 482791
Commit: f6375b5135bc913580bb50c2c0736fd808aea24a (subsequent changes)
Merge: e5183b9dc89e33607f09e7c5abb103c9f1a62d55

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/21299393090

---

x86_64-linux

❌ 1 package failed to build:

• ayatana-indicator-session

✅ 82 packages built:

• adapta-gtk-theme
• budgie-analogue-clock-applet
• budgie-control-center
• budgie-control-center.debug
• budgie-desktop
• budgie-desktop-with-plugins
• budgie-desktop.dev
• budgie-desktop.man
• budgie-gsettings-overrides
• budgie-session
• budgie-session.debug
• budgie-session.man
• budgie-systemmonitor-applet
• budgie-user-indicator-redux
• gnome-browser-connector
• gnome-control-center
• gnome-control-center.debug
• gnome-disk-utility
• gnome-session
• gnome-session.debug
• gnome-session.sessions
• gnome-settings-daemon
• gnome-shell
• gnome-shell.debug
• gnome-shell.devdoc
• gnome-tweaks
• gnome.nixos-gsettings-overrides
• gnomeExtensions.easyScreenCast
• gnomeExtensions.gsconnect
• gnomeExtensions.gsconnect.installedTests
• magpie
• magpie.debug
• magpie.dev
• magpie.devdoc
• marble-shell-theme
• matrix-gtk-theme
• mojave-gtk-theme
• mutter
• mutter.debug
• mutter.dev
• mutter.devdoc
• mutter.man
• mutter46 (pantheon.mutter)
• mutter46.debug (pantheon.mutter.debug)
• mutter46.dev (pantheon.mutter.dev)
• mutter46.devdoc (pantheon.mutter.devdoc)
• mutter46.man (pantheon.mutter.man)
• pantheon-tweaks
• pantheon.elementary-greeter
• pantheon.elementary-gsettings-schemas
• pantheon.elementary-monitor
• pantheon.elementary-session-settings
• pantheon.elementary-shortcut-overlay
• pantheon.gala
• pantheon.switchboard-plug-bluetooth
• pantheon.switchboard-plug-mouse-touchpad
• pantheon.switchboard-plug-pantheon-shell
• pantheon.switchboard-plug-power
• pantheon.switchboard-plug-security-privacy
• pantheon.switchboard-with-plugs
• pantheon.wingpanel
• pantheon.wingpanel-applications-menu
• pantheon.wingpanel-indicator-a11y
• pantheon.wingpanel-indicator-bluetooth
• pantheon.wingpanel-indicator-datetime
• pantheon.wingpanel-indicator-keyboard
• pantheon.wingpanel-indicator-network
• pantheon.wingpanel-indicator-nightlight
• pantheon.wingpanel-indicator-notifications
• pantheon.wingpanel-indicator-power
• pantheon.wingpanel-indicator-sound
• pantheon.wingpanel-quick-settings
• pantheon.wingpanel-with-indicators
• phoc
• phosh
• phosh-mobile-settings
• streamcontroller
• themechanger
• tokyonight-gtk-theme
• vimix-gtk-themes
• wingpanel-indicator-namarupa
• xdg-desktop-portal-gtk

---

Error logs: `x86_64-linux`

ayatana-indicator-session

** (process:2444): WARNING **: 20:04:59.770: /build/source/src/backend-dbus/utils.c:50 on_proxy_ready_impl: Error calling StartServiceByName for org.freedesktop.DisplayManager: The connection is closed
** (process:2444): CRITICAL **: 20:05:00.073: my_switch_to_username: assertion 'p->dm_seat != NULL' failed
** (process:2444): ERROR **: 20:05:04.983: /build/source/tests/gtest-dbus-fixture.h:104: timed out waiting for signal '`\u001fI'

cleaning up pid 2481
Start 3: test-guest

3/4 Test #3: test-guest .......................   Passed    0.96 sec

Start 4: test-users

4/4 Test #4: test-users .......................   Passed    1.33 sec
75% tests passed, 1 tests failed out of 4
Total Test time (real) =  34.22 sec
The following tests FAILED:

2 - test-actions (SIGTRAP)

Errors while running CTest

make: *** [Makefile:71: test] Error 8

---

aarch64-linux

✅ 83 packages built:

• adapta-gtk-theme
• ayatana-indicator-session
• budgie-analogue-clock-applet
• budgie-control-center
• budgie-control-center.debug
• budgie-desktop
• budgie-desktop-with-plugins
• budgie-desktop.dev
• budgie-desktop.man
• budgie-gsettings-overrides
• budgie-session
• budgie-session.debug
• budgie-session.man
• budgie-systemmonitor-applet
• budgie-user-indicator-redux
• gnome-browser-connector
• gnome-control-center
• gnome-control-center.debug
• gnome-disk-utility
• gnome-session
• gnome-session.debug
• gnome-session.sessions
• gnome-settings-daemon
• gnome-shell
• gnome-shell.debug
• gnome-shell.devdoc
• gnome-tweaks
• gnome.nixos-gsettings-overrides
• gnomeExtensions.easyScreenCast
• gnomeExtensions.gsconnect
• gnomeExtensions.gsconnect.installedTests
• magpie
• magpie.debug
• magpie.dev
• magpie.devdoc
• marble-shell-theme
• matrix-gtk-theme
• mojave-gtk-theme
• mutter
• mutter.debug
• mutter.dev
• mutter.devdoc
• mutter.man
• mutter46 (pantheon.mutter)
• mutter46.debug (pantheon.mutter.debug)
• mutter46.dev (pantheon.mutter.dev)
• mutter46.devdoc (pantheon.mutter.devdoc)
• mutter46.man (pantheon.mutter.man)
• pantheon-tweaks
• pantheon.elementary-greeter
• pantheon.elementary-gsettings-schemas
• pantheon.elementary-monitor
• pantheon.elementary-session-settings
• pantheon.elementary-shortcut-overlay
• pantheon.gala
• pantheon.switchboard-plug-bluetooth
• pantheon.switchboard-plug-mouse-touchpad
• pantheon.switchboard-plug-pantheon-shell
• pantheon.switchboard-plug-power
• pantheon.switchboard-plug-security-privacy
• pantheon.switchboard-with-plugs
• pantheon.wingpanel
• pantheon.wingpanel-applications-menu
• pantheon.wingpanel-indicator-a11y
• pantheon.wingpanel-indicator-bluetooth
• pantheon.wingpanel-indicator-datetime
• pantheon.wingpanel-indicator-keyboard
• pantheon.wingpanel-indicator-network
• pantheon.wingpanel-indicator-nightlight
• pantheon.wingpanel-indicator-notifications
• pantheon.wingpanel-indicator-power
• pantheon.wingpanel-indicator-sound
• pantheon.wingpanel-quick-settings
• pantheon.wingpanel-with-indicators
• phoc
• phosh
• phosh-mobile-settings
• streamcontroller
• themechanger
• tokyonight-gtk-theme
• vimix-gtk-themes
• wingpanel-indicator-namarupa
• xdg-desktop-portal-gtk

[jtojnar]

Thanks.