buildDubPackage: fix flag arrays not being expanded correctly#486535
buildDubPackage: fix flag arrays not being expanded correctly#486535TomaSajt merged 1 commit intoNixOS:masterfrom
Conversation
Use concatTo to properly handle dubBuildFlags, dubTestFlags, and
dubFlags. Previously these were used as "${var[@]}" but Nix lists
become space-separated strings, not bash arrays, causing all flags
to be concatenated into a single argument.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Somewhat related to #205690 - perhaps you could migrate the dub infrastructure to |
|
That would be nice. @TomaSajt What do you think? |
|
I am not very experienced in bash array stuff. I don't know how to use Does the current solution work with and without |
If you mean the solution in master right now, no; with this fix, it does seem to work with and without |
TomaSajt
left a comment
There was a problem hiding this comment.
If that's the case, then LGTM.
|
Successfully created backport PR for |
Use concatTo to properly handle dubBuildFlags, dubTestFlags, and dubFlags. Previously these were used as "${var[@]}" but Nix lists become space-separated strings, not bash arrays, causing all flags to be concatenated into a single argument.
Motivating example:
became:
CC @TomaSajt
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.