buildDubPackage: split into hooks and into importDubLock

[TomaSajt]

Description of changes

This PR splits buildDubPackage into dub{Setup,Build,Check}Hook and importDubLock

importDubLock just creates the directory structure that will be copied into $DUB_HOME by the setup hook. It's not compressed.

---

I wasn't able to include the compiler parameter of buildDubPackage in the build hook, since it uses lib.getExe and it has extra stripping logic attached to it.

---

A question that still remains is: should it be dubSetupHook or dubConfigHook and which hook should it be the part of. (postPatch and preConfigure seem like good options to me.)

---

The API did not change, so the docs do not really have to be changed.
The default values are still marked with ? defaultVal in the docs, whereas the new hooks use shell parameter expansion for defaults, but I think that's fine.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[jtbx]

From a quick glance looks good. If it works it works, I would prefer if the build support files were in a subdirectory away from the package.

[AndersonTorres]

I would suggest you to keep them inside pkgs/by-name/dub/build-support/.

[TomaSajt]

I reverted the part that moved from the original directories. We don't really have to do that in this PR.

[philiptaron]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 344744
Commit: d3f69ec125f908a34379e56a71a3aa5d71865fe9

---

x86_64-linux

❌ 1 package failed to build:

• dstep

✅ 10 packages built:

• btdu
• dub-to-nix
• dubBuildHook
• dubCheckHook
• dubSetupHook
• inochi-creator
• inochi-session
• literate
• luneta
• serve-d

---

Error logs: `x86_64-linux`

dstep

----------------
??:? [0x45f5d6]
??:? [0x45f242]
??:? [0x48565e]
??:? [0x4674ef]
??:? [0x42cf55]
??:? [0x42c434]
??:? [0x429505]
??:? [0x428255]
??:? [0x407f1e]
??:? [0x4077c6]
??:? [0x407343]
??:? [0x4671cc]
??:? [0x4670c6]
??:? [0x466f1c]
??:? [0x408d41]
??:? [0x7ffff7c2a4d7]
??:? __libc_start_main [0x7ffff7c2a59a]
??:? [0x404a14]
Error: /build/configure-55383a failed with status: 1

[philiptaron]

Could you please take a look at the dstep failure?

[TomaSajt]

Fixed.
Now, just like before this PR, configurePhase will not run the default ./configure logic
(This is similar to buildRustPackage, where the entire configurePhase is just calling the pre and post hooks)

[philiptaron]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 344744
Commit: 2d62506a97b2ba80c378756c78bdebba0ab6be89

---

x86_64-linux

✅ 11 packages built:

• btdu
• dstep
• dub-to-nix
• dubBuildHook
• dubCheckHook
• dubSetupHook
• inochi-creator
• inochi-session
• literate
• luneta
• serve-d