Skip to content

buildDubPackage: fix flag arrays not being expanded correctly #486535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomaSajt merged 1 commit into from
Feb 4, 2026
Merged

buildDubPackage: fix flag arrays not being expanded correctly #486535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkgs/build-support/dlang/builddubpackage/hooks/dub-build-hook.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,14 @@ dubBuildHook() {
runHook preBuild
echo "Executing dubBuildHook"

dub build --skip-registry=all --build="${dubBuildType-"release"}" "${dubBuildFlags[@]}" "${dubFlags[@]}"
local flagsArray=(
--skip-registry=all
"--build=${dubBuildType-release}"
)
concatTo flagsArray dubBuildFlags dubFlags

echoCmd 'dubBuildHook flags' "${flagsArray[@]}"
dub build "${flagsArray[@]}"

echo "Finished dubBuildHook"
runHook postBuild
Expand Down
8 changes: 7 additions & 1 deletion pkgs/build-support/dlang/builddubpackage/hooks/dub-check-hook.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@ dubCheckHook() {
runHook preCheck
echo "Executing dubCheckHook"

dub test --skip-registry=all "${dubTestFlags[@]}" "${dubFlags[@]}"
local flagsArray=(
--skip-registry=all
)
concatTo flagsArray dubTestFlags dubFlags

echoCmd 'dubCheckHook flags' "${flagsArray[@]}"
dub test "${flagsArray[@]}"

echo "Finished dubCheckHook"
runHook postCheck
Expand Down
Loading