Skip to content

Revert "wireplumber: 0.5.12 -> 0.5.13"#482761

Closed
flokli wants to merge 1 commit intoNixOS:masterfrom
flokli:wireplumber-revert
Closed

Revert "wireplumber: 0.5.12 -> 0.5.13"#482761
flokli wants to merge 1 commit intoNixOS:masterfrom
flokli:wireplumber-revert

Conversation

@flokli
Copy link
Member

@flokli flokli commented Jan 22, 2026

This reverts commit fb498a5.

It entirely crashes graphical gnome sessions when switching to the handsfree profile, either automatically or whenever pipewire decides to auto-switch.

Let's revert until there's a fix.

Fixes #475202.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

This reverts commit fb498a5.

It entirely crashes graphical gnome sessions when switching to the
handsfree profile, either automatically or whenever pipewire decides
to auto-switch.

Let's revert until there's a fix.

Fixes NixOS#475202.
@flokli flokli requested a review from K900 January 22, 2026 17:55
@flokli flokli mentioned this pull request Jan 22, 2026
13 tasks
@flokli
Copy link
Member Author

flokli commented Jan 22, 2026

We can keep an eye on https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/merge_requests/31, and reapply with that as a patch, or another fix.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jan 22, 2026
@K900
Copy link
Contributor

K900 commented Jan 22, 2026

I would prefer picking the GNOME patch.

@flokli
Copy link
Member Author

flokli commented Jan 22, 2026

But it's multiple things needing fixing (https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/merge_requests/31#note_2650416), no full patch yet, and meanwhile we're crashing user settings whenever the Bluetooth device connects, potentially having users loose data, simply by powering on your already-paired Bluetooth device in some cases.

It's a pretty drastic bug, we don't really need the new version of wireplumber to fix some other bugs, so the revert should be a no-brainer.

@K900
Copy link
Contributor

K900 commented Jan 22, 2026

There is more issues than just this, the Wireplumber update just happens to surface the bug more often, see e.g. https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/2654

@flokli flokli requested a review from jtojnar January 22, 2026 18:22
@limwa
Copy link
Contributor

limwa commented Jan 22, 2026

I would prefer picking the GNOME patch.

As far as I am aware, gvc's source is included in every project that depends on it, so it would require patching every GNOME package that depends on gvc. So gnome-shell, gnome-control-center, ... But if you can get me a list of packages that depend on gvc, I wouldn't mind opening PRs to patch all of them.

Another option that wasn't mentioned previously is to also package wireplumber 0.5.12 as wireplumber_0_5_12 and, if gnome-shell is enabled, use that as the package for wireplumber. I'm not sure if they're interchangeable, though, so this could cause other problems.

Reverting does sound like the best option here, even with its downsides.

EDIT: gvc has all of the GNOME projects that depend on it in their README. I'll start working on the PRs.

@limwa
Copy link
Contributor

limwa commented Jan 22, 2026

Opened #482791

@limwa
Copy link
Contributor

limwa commented Jan 24, 2026

The PR I opened was merged, so I think there is no need to revert now. Thank you!

@flokli
Copy link
Member Author

flokli commented Jan 27, 2026

I can confirm #482791 seems to also fix the issue for me. thanks.

@flokli flokli closed this Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gnome-settings-daemon, gnome-shell: crash on Handsfree Bluetooth connection

3 participants