Revert "wireplumber: 0.5.12 -> 0.5.13"#482761
Conversation
This reverts commit fb498a5. It entirely crashes graphical gnome sessions when switching to the handsfree profile, either automatically or whenever pipewire decides to auto-switch. Let's revert until there's a fix. Fixes NixOS#475202.
|
We can keep an eye on https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/merge_requests/31, and reapply with that as a patch, or another fix. |
|
I would prefer picking the GNOME patch. |
|
But it's multiple things needing fixing (https://gitlab.gnome.org/GNOME/libgnome-volume-control/-/merge_requests/31#note_2650416), no full patch yet, and meanwhile we're crashing user settings whenever the Bluetooth device connects, potentially having users loose data, simply by powering on your already-paired Bluetooth device in some cases. It's a pretty drastic bug, we don't really need the new version of wireplumber to fix some other bugs, so the revert should be a no-brainer. |
|
There is more issues than just this, the Wireplumber update just happens to surface the bug more often, see e.g. https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/2654 |
As far as I am aware, gvc's source is included in every project that depends on it, so it would require patching every GNOME package that depends on gvc. So gnome-shell, gnome-control-center, ... Another option that wasn't mentioned previously is to also package wireplumber 0.5.12 as Reverting does sound like the best option here, even with its downsides. EDIT: gvc has all of the GNOME projects that depend on it in their README. I'll start working on the PRs. |
|
Opened #482791 |
|
The PR I opened was merged, so I think there is no need to revert now. Thank you! |
|
I can confirm #482791 seems to also fix the issue for me. thanks. |
This reverts commit fb498a5.
It entirely crashes graphical gnome sessions when switching to the handsfree profile, either automatically or whenever pipewire decides to auto-switch.
Let's revert until there's a fix.
Fixes #475202.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.