Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
53 tasks
dotlambda
requested changes
Oct 25, 2025
aduh95
force-pushed
the
corepack
branch
5 times, most recently
from
e0d7191 to
a179344
Compare
Member
|
It doesn't even build. |
Contributor
Author
Ah OfBorg has the same error I was talking in #455502 (comment). Now I have to wonder why I no longer see it locally – anyways, I've added the patch back |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Contributor
Author
|
@dotlambda are you still -1 on this PR? |
dotlambda
reviewed
Nov 6, 2025
aduh95
force-pushed
the
corepack
branch
2 times, most recently
from
5148858 to
725aee4
Compare
aduh95
force-pushed
the
corepack
branch
2 times, most recently
from
c4b3150 to
0fed38d
Compare
aduh95
force-pushed
the
corepack
branch
2 times, most recently
from
0242779 to
030e175
Compare
dotlambda
reviewed
Nov 14, 2025
aduh95
force-pushed
the
corepack
branch
2 times, most recently
from
2bcb501 to
d4a692f
Compare
Contributor
Author
|
@dotlambda are you still requesting changes on this PR? I've done my best to address your comments and OfBorg is reasonably happy. |
13 tasks
aduh95
force-pushed
the
corepack
branch
2 times, most recently
from
20d7bdc to
9319a45
Compare
dotlambda
approved these changes
Nov 24, 2025
dotlambda
reviewed
Nov 24, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
Author
|
Any chance this could get merged? It's kinda blocking the |
fabianhjr
approved these changes
Nov 27, 2025
Aleksanaa
reviewed
Dec 10, 2025
pinage404
reviewed
Jan 17, 2026
| stdenvNoCC, | ||
| cacert, | ||
| yarn-berry, | ||
| nodejs, |
Contributor
There was a problem hiding this comment.
If we use corepack, I assume, in most of the cases, that we don't use NPM
So, why are we using nodejs instead of nodejs-slim ? @fabianhjr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.