Skip to content

versionCheckHook: use coreutils env; gzip: add passthru test#474625

Closed
mdaniels5757 wants to merge 2 commits intoNixOS:stagingfrom
mdaniels5757:repro-versionCheckHook-issue
Closed

versionCheckHook: use coreutils env; gzip: add passthru test#474625
mdaniels5757 wants to merge 2 commits intoNixOS:stagingfrom
mdaniels5757:repro-versionCheckHook-issue

Conversation

@mdaniels5757
Copy link
Member

@mdaniels5757 mdaniels5757 commented Dec 27, 2025 •
edited
Loading

When running nix-build -A gzip.passthru.test without the second commit, the first commit fails, because it pulls in less during the bootstrap, and less uses versionCheckHook, which needs coreutils 9.5+, but (due to the outdated bootstrap tools) only has coreutils 9.4 for the in-bootstrap compilation.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@mdaniels5757
gzip: add passthru test
dfb450e
@mdaniels5757
versionCheckHook: use coreutils env
1e6ace3 
I was getting an "env: unrecognized option '--argv0=less'"
error when using a package that used this hook in the bootstrap sequence.
@mdaniels5757 mdaniels5757 mentioned this pull request Dec 27, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 27, 2025
doronbehar
doronbehar approved these changes Dec 28, 2025
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, why is this a draft?

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Dec 28, 2025
@mdaniels5757 mdaniels5757 changed the base branch from master to staging December 28, 2025 14:53
@nixpkgs-ci nixpkgs-ci bot closed this Dec 28, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Dec 28, 2025
@mdaniels5757 mdaniels5757 changed the title [Do not merge] {versionCheckHook,gzip.passthru.tests}: reproduce issue versionCheckHook: use coreutils env; gzip: add passthru test Dec 28, 2025
@mdaniels5757
Copy link
Member Author

mdaniels5757 commented Dec 28, 2025

Because I want to merge #474203 instead, to avoid merge conflicts with #474210.

@mdaniels5757 mdaniels5757 deleted the repro-versionCheckHook-issue branch December 28, 2025 15:06
@mdaniels5757 mdaniels5757 mentioned this pull request Dec 28, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdaniels5757 @doronbehar