versionCheckHook: use current coreutils env

[mdaniels5757]

I was getting an "env: unrecognized option '--argv0=less'" error when using a package that used this hook in the bootstrap sequence.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[mdaniels5757]

Tested (on x86_64-linux) both the modified package that I noticed the issue on (uncommitted passthru.tests for gzip), and normal less (which worked before). Both now work.

[doronbehar]

I was getting an "env: unrecognized option '--argv0=less'" error when using a package that used this hook in the bootstrap sequence.

Could you give an example for a package in the bootstrap sequence that would not fail thanks to the changes here? Will you be using a different env implementation or something?

[mdaniels5757]

The only example I'm aware of is that, in #474210, versionCheckHook fails for less while building gzip.passthru.tests. (You can also see the ofborg logs on that PR.) versionCheckHook succeeds when building gzip.passthru.tests if I cherry-pick this PR's commit to #474210's branch.

[mdaniels5757]

It looks like the root cause is that the bootstrap tools use coreutils 9.4, and --argv0 was added in coreutils 9.5 (coreutils/coreutils@193449b). Maybe the better solution is to update the bootstrap tarballs, in that case?

[doronbehar]

It looks like the root cause is that the bootstrap tools use coreutils 9.4, and --argv0 was added in coreutils 9.5 (coreutils/coreutils@193449b). Maybe the better solution is to update the bootstrap tarballs, in that case?

OK thanks for explaining. I'm still a bit confused though as for gzip.passthru.tests because I don't see them in branch master, and in #474210 I don't see anything related to versionCheckHook. Maybe you could cherry pick the commit here to #474210 and then it'll be easier to see the changes? I won't mind reviewing the rest of #474210 which looks good on first sight :).

[mdaniels5757]

See #474625

[mdaniels5757]

This commit was approved by doronbehar in #474625, but I will merge this PR separately from the gzip change to avoid merge conflicts with #474210.