beets: make it easier to override builtin plugins by 9999years · Pull Request #471166 · NixOS/nixpkgs

9999years · 2025-12-15T22:06:38Z

Previously, it was possible to override builtin plugins. Now it's not. After this commit, it is again :)

You may have a patch (e.g. a not-yet-merged or not-yet-released PR) that adds a new builtin plugin.

Things done

Add a 👍 reaction to pull requests you find important.

doronbehar · 2025-12-18T11:30:53Z

Hey, thanks for the PR! Your approach on first sight seems better then mine:

python3.pkgs.beets: allow to override passthru #467091

Could you give an example for an overlay using your change here? Indeed my overlay example seems pretty clumsy so I'd like to compare these overlays' clumsiness :).

9999years · 2025-12-22T20:07:43Z

@doronbehar Thanks for the prompt! I added a couple of new passthru.tests attributes, and found a bug in my implementation! (I needed lib.filterAttrs (_: p: p.builtin or false) to handle missing attributes.)

Here's a usage example:

(beets.override {
  pluginOverrides = {
    my_special_plugin.builtin = true;
  };
}).overridePythonAttrs
  (prev: {
    postPatch = (prev.postPatch or "") + ''
      mkdir -p beetsplug/my_special_plugin
      touch beetsplug/my_special_plugin/__init__.py
    '';
  });

https://github.com/NixOS/nixpkgs/blob/379808b7dcdd0dbdf85b367401c126c11605ab9c/pkgs/development/python-modules/beets/default.nix#L498-L509

I also added an example of building beets with the beetcamp plugin enabled, which annoyingly requires a separate overridePythonAttrs to set dontUsePythonCatchConflicts = true, because beetcamp depends on beets, but the derivation hashes can't match:

https://github.com/9999years/nixpkgs/blob/185e8e16f746a975245c3aa904002d63c944f584/pkgs/development/python-modules/beets/default.nix#L481-L496

doronbehar

This approach is great. I have another nit request if you can please: Could you put the passthru.tests in 1 commit, and then fix beets.passthru.tests.beets-with-new-builtin-plugin in a 2nd commit? It'd be easier to see the fix more clearly. Also, in the 1st commit I'd put also a note in the big comment at the beginning of the file pointing out the examples in passthru.tests.

pkgs/development/python-modules/beets/default.nix

doronbehar · 2025-12-23T09:27:55Z

BTW On a 2nd thought, I think that my changes in #467091 don't contradict the changes here, and should be useful anyway. @9999years Could you review my changes there and then we can continue here?

doronbehar · 2025-12-23T09:45:48Z

Oh and I almost forgot: The commit fixing beetcamp should be a separate commit too.

9999years · 2025-12-23T21:35:44Z

Sure, I'm going to split the beetcamp stuff into a separate PR (#473678). This should be easier to approve now. PTAL, thanks!

This will make it possible to use `beetcamp` without setting `dontUsePythonCatchConflicts = true` in an override. See: NixOS#471166 (comment)

doronbehar

Changes look good. I think this should be good to go but I'd prefer to only approve it in the meantime so the other PRs could be coordinated.

This will make it possible to use `beetcamp` without setting `dontUsePythonCatchConflicts = true` in an override. See: NixOS#471166 (comment)

9999years · 2025-12-24T20:14:41Z

Fixed merge conflicts.

doronbehar · 2025-12-25T10:22:33Z

I forced pushed the same changes but with a different commit message, as now it is easier to override built in plugins - it was possible (but clumsy) thanks to my PR #467091 .

doronbehar

Hmm the beets.passthru.tests.beets-with-new-builtin-plugin fail..

doronbehar · 2026-01-05T09:24:59Z

@9999years now since #271387 is now merged, I managed to create a working override test in #477084 , so I wish to close this. Is it OK with you?

9999years · 2026-01-13T06:14:13Z

@doronbehar Once you have a PR which removes the pluginOverrides argument, then sure

doronbehar · 2026-01-13T10:12:38Z

Thanks for finding the time to comment :). We can discuss removing (or not) pluginOverrides in #477084 .

9999years · 2026-01-14T19:12:35Z

This PR is very small (17 lines) and still applicable; I've looked at this derivation a ton lately and I'm still not sure how to override builtin plugins without it.

I'm not sure I understand the hesitancy to merge it / the rush to close it. The design in #477084 is likely better in the longer term (although there's a ton of passthru attributes that are not super obvious to users looking to edit the set of enabled plugins, e.g. base vs overrides vs enabled), but definitely more complex.

Can we get this merged to fix that issue and then move on to #477084? I've been a little frustrated with you asking for changes and then insisting on merging your own PRs first (and having me rebase), even if they're more complex, and then finally closing my PR without merging it. I feel like I've wasted a lot of effort here and my initial issue (pluginOverrides cannot be used to override builtin plugins) is still not solved.

doronbehar · 2026-01-14T22:23:36Z

Can we get this merged to fix that issue and then move on to #477084? I've been a little frustrated with you asking for changes and then insisting on merging your own PRs first (and having me rebase), even if they're more complex, and then finally closing my PR without merging it. I feel like I've wasted a lot of effort here and my initial issue (pluginOverrides cannot be used to override builtin plugins) is still not solved.

I wouldn't have minded at all approving and merging this PR before #271387 got merged and I updated my PR. It's just that beets.passthru.tests.beets-with-new-builtin-plugin fails here... I commented about it earlier. Also, I truly don't see how these 2 PRs will go along together, and finalAttrs pattern is so much better.

Previously, it required a `let in`: NixOS#467091

9999years · 2026-01-16T18:42:16Z

OK. I think this is something of a "perfect is the enemy of the good" situation, and this PR would help fix a use-case today while we make sure #477084 is good to go, but we will have to agree to disagree.

I do think that #477084 (finalAttrs) is a much better long-term solution, but I know that getting finalAttrs rolled out across Nixpkgs has been a tricky and long process, so I'm a bit nervous about getting it in quickly without any weird breakages.

doronbehar · 2026-01-18T11:33:22Z

pkgs/development/python-modules/beets/default.nix

+        let
+          beets-with-new-builtin-plugin =
+            (beets.override {
+              beets = beets-with-new-builtin-plugin;
+
+              pluginOverrides = {
+                my_special_plugin.builtin = true;
+              };
+            }).overridePythonAttrs
+              (prev: {
+                postPatch = (prev.postPatch or "") + ''
+                  mkdir -p beetsplug/my_special_plugin
+                  touch beetsplug/my_special_plugin/__init__.py
+                '';
+              });
+        in
+        beets-with-new-builtin-plugin;


I see now how you fixed it! Pretty delicate indeed :).

9999years requested review from aszlig and doronbehar and removed request for doronbehar December 17, 2025 21:33

nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Dec 17, 2025

9999years force-pushed the wiggles/vxuy branch from bc3a484 to 185e8e1 Compare December 22, 2025 20:05

doronbehar reviewed Dec 23, 2025

View reviewed changes

9999years force-pushed the wiggles/vxuy branch from 185e8e1 to 587d99b Compare December 23, 2025 21:35

9999years mentioned this pull request Dec 23, 2025

beetcamp: move beets dependency to nativeBuildInputs #473678

Merged

13 tasks

doronbehar approved these changes Dec 24, 2025

View reviewed changes

nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 24, 2025

9999years force-pushed the wiggles/vxuy branch from 587d99b to ea4b924 Compare December 24, 2025 20:04

nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 24, 2025

9999years requested a review from doronbehar December 24, 2025 20:14

doronbehar changed the title ~~beets: make it possible to override builtin plugins~~ beets: make it easier to override builtin plugins Dec 25, 2025

doronbehar force-pushed the wiggles/vxuy branch from ea4b924 to 036fd2f Compare December 25, 2025 10:19

doronbehar requested changes Dec 25, 2025

View reviewed changes

doronbehar marked this pull request as draft January 7, 2026 15:27

doronbehar marked this pull request as ready for review January 7, 2026 15:27

doronbehar closed this Jan 13, 2026

9999years reopened this Jan 14, 2026

python3.pkgs.beets: make it easier to override builtin plugins

fb900e5

Previously, it required a `let in`: NixOS#467091

9999years force-pushed the wiggles/vxuy branch from 036fd2f to fb900e5 Compare January 16, 2026 18:37

9999years closed this Jan 16, 2026

9999years deleted the wiggles/vxuy branch January 16, 2026 18:42

doronbehar reviewed Jan 18, 2026

View reviewed changes

Uh oh!

Conversation

9999years commented Dec 15, 2025

Things done

Uh oh!

doronbehar commented Dec 18, 2025

Uh oh!

9999years commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doronbehar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

doronbehar commented Dec 23, 2025

Uh oh!

doronbehar commented Dec 23, 2025

Uh oh!

9999years commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doronbehar left a comment

Choose a reason for hiding this comment

Uh oh!

9999years commented Dec 24, 2025

Uh oh!

doronbehar commented Dec 25, 2025

Uh oh!

doronbehar left a comment

Choose a reason for hiding this comment

Uh oh!

doronbehar commented Jan 5, 2026

Uh oh!

9999years commented Jan 13, 2026

Uh oh!

doronbehar commented Jan 13, 2026

Uh oh!

9999years commented Jan 14, 2026

Uh oh!

doronbehar commented Jan 14, 2026

Uh oh!

9999years commented Jan 16, 2026

Uh oh!

doronbehar Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

9999years commented Dec 22, 2025 •

edited

Loading

9999years commented Dec 23, 2025 •

edited

Loading