Skip to content

beets: make it easier to override builtin plugins #471166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
9999years wants to merge 1 commit into from
Closed

beets: make it easier to override builtin plugins #471166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions pkgs/development/python-modules/beets/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ buildPythonPackage {

passthru = {
plugins = {
builtins = {
builtins = lib.recursiveUpdate {
absubmit = {
deprecated = true;
testPaths = [ ];
Expand Down Expand Up @@ -441,7 +441,7 @@ buildPythonPackage {
_utils = {
testPaths = [ ];
};
};
} (lib.filterAttrs (_: p: p.builtin or false) pluginOverrides);
base = lib.mapAttrs (_: a: { builtin = true; } // a) beets.passthru.plugins.builtins;
overrides = lib.mapAttrs (
plugName:
Expand Down Expand Up @@ -485,6 +485,25 @@ buildPythonPackage {

${beets}/bin/beet -c $out/config.yaml > /dev/null
'';

beets-with-new-builtin-plugin =
let
beets-with-new-builtin-plugin =
(beets.override {
beets = beets-with-new-builtin-plugin;

pluginOverrides = {
my_special_plugin.builtin = true;
};
}).overridePythonAttrs
(prev: {
postPatch = (prev.postPatch or "") + ''
mkdir -p beetsplug/my_special_plugin
touch beetsplug/my_special_plugin/__init__.py
'';
});
in
beets-with-new-builtin-plugin;
Comment on lines +490 to +506
Copy link
Contributor

@doronbehar doronbehar Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now how you fixed it! Pretty delicate indeed :).

};
};

Expand Down
Loading