python3.pkgs.beets: allow to override passthru

[doronbehar]

Tested with:

diff --git i/pkgs/top-level/python-packages.nix w/pkgs/top-level/python-packages.nix
index 6051daa09f6a..2dde3c3c327b 100644
--- i/pkgs/top-level/python-packages.nix
+++ w/pkgs/top-level/python-packages.nix
@@ -1871,6 +1871,25 @@ self: super: with self; {
   beets = callPackage ../development/python-modules/beets {
     inherit (pkgs) chromaprint;
   };
+  beets-test = let
+    # Not using `overridePythonAttrs` because it doesn't produce a derivation
+    # with a `.override` method, as required later.
+    patched = beets.overrideAttrs(oldAttrs: {
+      patches = oldAttrs.patches ++ [
+        (pkgs.fetchpatch {
+          name = "beets-importsource-plugin.patch";
+          url = "https://github.com/beetbox/beets/commit/9608ec0925979356fb7bf3a870fbde760362a973.patch";
+          hash = "sha256-wseJe+2jS7hsKKJ5jWrkBlPmOkVwLhPS23PRMqAR7is=";
+        })
+      ];
+      passthru = lib.recursiveUpdate oldAttrs.passthru {
+        plugins.builtins.importsource = {};
+      };
+    });
+  in
+    patched.override {
+      beets = patched;
+    };
 
   beets-alternatives = callPackage ../development/python-modules/beets-alternatives { };
 

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[aszlig]

I think being able to override all attributes is generally a good thing.

I'm not so sure whether we want people to override use passthru for defining new plugin options, since I'd consider that to be internal.

What's the actual thing that motivated you to address this?

[doronbehar]

Thanks for the review :).

[doronbehar]

I'm not so sure whether we want people to override use passthru for defining new plugin options, since I'd consider that to be internal.

What's the actual thing that motivated you to address this?

See the example diff in the top level comment.

[9999years]

Suggested change

	# overriden. Until `finalAttrs` support reaches `buildPythonPackage`, there
	# is no way to avoid this.
	# overriden. Until `finalAttrs` support reaches `buildPythonPackage`, there
	# is no way to avoid this.
	#
	# See: https://github.com/NixOS/nixpkgs/issues/258246

Nice to have a link to the relevant issue here.

[doronbehar]

Nice to have a link to the relevant issue here.

I agree!

[9999years]

Kind of rough usage here; probably worth a comment or a passthru.tests attribute. Still nice to be able to do this.

[doronbehar]

Kind of rough usage here; probably worth a comment or a passthru.tests attribute. Still nice to be able to do this.

I agree, your PR will make this UX better :).

[trofi]

Bisect says that this caused infinite recursion eval failure (was python version failure before):

$ nix-instantiate -A pypy2Packages.beets
error:
       … while evaluating a branch condition
         at pkgs/development/interpreters/python/passthrufun.nix:43:13:
           42|             name: value:
           43|             if lib.isDerivation value then
             |             ^
           44|               lib.extendDerivation (

       … while calling a functor (an attribute set with a '__functor' attribute)
         at lib/customisation.nix:334:7:
          333|     if missingArgs == { } then
          334|       makeOverridable f allArgs
             |       ^
          335|     # This needs to be an abort so it can't be caught with `builtins.tryEval`,

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: infinite recursion encountered
       at pkgs/development/python-modules/beets/default.nix:216:5:
          215|   disabledTestPaths =
          216|     beets.passthru.plugins.disabledTestPaths
             |     ^
          217|     ++ [

[doronbehar]

Damn you are right. I'm sorry about that and I wish Python packages had a .overrideAttrs(final: prev: style overriding possible...

#258246

I'm open to implementing a workaround just for beets though.

[doronbehar]

Just for reference, now with #271387 merged 🎉, and with the changes here:

• python3.pkgs.beets: use fixed-point arguments #477084

A much nicer override is possible, and is part of a new passthru.tests test there. Your review is welcome.

[doronbehar]

Oh and @trofi FYI it seems that #271387 hasn't helped instantiating pypyPackages.beets. On the branch of #477084 . See:

• pypyPackages & python2Packages cannot instantiate expressions with fixed-point arguments to buildPython* #477098