Skip to content

Comments

[25.05] feishin: 0.12.6 -> 0.21.2, bump electron from 36 to 38 #464527

Closed
teutat3s wants to merge 4 commits intoNixOS:release-25.05from
teutat3s:feishin-backports
Closed

[25.05] feishin: 0.12.6 -> 0.21.2, bump electron from 36 to 38 #464527
teutat3s wants to merge 4 commits intoNixOS:release-25.05from
teutat3s:feishin-backports

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented Nov 24, 2025

Backports of:

Related to electron_36 EOL: #461995

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

ThinkChaos and others added 4 commits November 24, 2025 11:32
@ThinkChaos @teutat3s
feishin: 0.12.6 -> 0.20.1
9f0b738 
(cherry picked from commit 8c4c816)
@yuri-becker @teutat3s
feishin 0.20.1 -> 0.21.2
af35832 
(cherry picked from commit a38cdcd)
@yuri-becker @teutat3s
Fix Darwin build error
ad7f7d9 
(cherry picked from commit 0fda0e3)
@Daste745 @teutat3s
feishin: Bump electron from 36 to 38
d17665c 
Feishin will be using electron 38 in version 0.21.3, which is
currently in beta.

While we're still on 0.21.2, bumping electron doesn't break the app and
it still works as expected.

Also resolves a warning about Electron versions below 37.0.0 being EOL.

(cherry picked from commit b0e7468)
@teutat3s teutat3s mentioned this pull request Nov 24, 2025
Merged
28 tasks
@nixpkgs-ci nixpkgs-ci bot requested review from jlbribeiro and onny November 24, 2025 10:44
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 4.workflow: backport This targets a stable branch labels Nov 24, 2025
@leona-ya
Copy link
Member

leona-ya commented Jan 2, 2026

NixOS 25.05 is end of life, so this PR won't be merged anymore. Closing it. Ref #443568.

@leona-ya leona-ya closed this Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlbribeiro jlbribeiro Awaiting requested review from jlbribeiro

@onny onny Awaiting requested review from onny

Assignees

No one assigned

Labels

4.workflow: backport This targets a stable branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@teutat3s @leona-ya @ThinkChaos @yuri-becker @Daste745