Skip to content

Comments

feishin: fix #455297 and 0.20.1 -> 0.21.2#455302

Merged
onny merged 2 commits intoNixOS:masterfrom
yuri-becker:update-feishin
Oct 25, 2025
Merged

feishin: fix #455297 and 0.20.1 -> 0.21.2#455302
onny merged 2 commits intoNixOS:masterfrom
yuri-becker:update-feishin

Conversation

@yuri-becker
Copy link
Contributor

@yuri-becker yuri-becker commented Oct 24, 2025

Fix for the issue described in #455297 and bumped the package version.

The last upgrade for Feishin in Nixpkgs broke the build for Darwin. Simply, this is because Feishin changed its build output - which was compensated for in the installPhase for Linux, but not for Darwin (see change in line 105 at https://github.com/NixOS/nixpkgs/pull/445926/files).

I also took the opportunity to update to the newest Feishin release, I hope that's okay.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels Oct 24, 2025
@nix-owners nix-owners bot requested review from jlbribeiro and onny October 24, 2025 17:19
@nolith
Copy link
Contributor

nolith commented Oct 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 455302
Commit: 0fda0e38cfb6949fde8a0917fcd89f759b01de13


x86_64-darwin

✅ 1 package built:
  • feishin

@nolith
Copy link
Contributor

nolith commented Oct 25, 2025

Tested on x86_64-darwin. The app works well.

Thanks for fixing this

@onny
Copy link
Contributor

onny commented Oct 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 455302
Commit: 0fda0e38cfb6949fde8a0917fcd89f759b01de13


x86_64-linux

✅ 1 package built:
  • feishin

@onny onny merged commit 7194432 into NixOS:master Oct 25, 2025
31 checks passed
@onny
Copy link
Contributor

onny commented Oct 25, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants