feishin: fix #455297 and 0.20.1 -> 0.21.2#455302
Merged
onny merged 2 commits intoNixOS:masterfrom Oct 25, 2025
yuri-becker:update-feishin
Merged
feishin: fix #455297 and 0.20.1 -> 0.21.2#455302onny merged 2 commits intoNixOS:masterfrom yuri-becker:update-feishin
onny merged 2 commits intoNixOS:masterfrom
yuri-becker:update-feishin
Conversation
Contributor
|
Contributor
|
Tested on x86_64-darwin. The app works well. Thanks for fixing this |
Contributor
|
Contributor
|
Thank you! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue described in #455297 and bumped the package version.
The last upgrade for Feishin in Nixpkgs broke the build for Darwin. Simply, this is because Feishin changed its build output - which was compensated for in the installPhase for Linux, but not for Darwin (see change in line 105 at https://github.com/NixOS/nixpkgs/pull/445926/files).
I also took the opportunity to update to the newest Feishin release, I hope that's okay.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.