fish: misc fixes for new default standalone build#461265
Merged
adamcstephens merged 1 commit intoNixOS:masterfrom Nov 13, 2025
Merged
fish: misc fixes for new default standalone build#461265adamcstephens merged 1 commit intoNixOS:masterfrom
adamcstephens merged 1 commit intoNixOS:masterfrom
Conversation
Fish no longer sources most files in `$out/share/fish` with 4.2.0, and instead embeds these files in the fish binary itself: > The standalone build mode has been made the default. This means that > the files in $CMAKE_INSTALL_PREFIX/share/fish will not be used > anymore, except for HTML docs. As a result, future upgrades will no > longer break running shells if one of fish’s internal helper functions > has been changed in the updated version. For now, the data files are > still installed redundantly, to prevent upgrades from breaking > already-running shells. To reverse this change (which should not be > necessary), patch out the embed-data feature from cmake/Rust.cmake. > This option will be removed in future. This means that any changes to these files now have to be made the input before the build system tries to embed them.
nixpkgs-ci
bot
requested review from
SigmaSquadron,
adamcstephens,
cole-h,
lonerOrz,
r-vdp and
winterqt
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
Member
|
Perhaps we can solve this together at #461243. |
Contributor
|
My understanding of this migration is that we probably want to keep patching |
Contributor
Author
|
@lonerOrz sorry, didn't see that pr. |
Contributor
It's fine to do this separately since it's already open. |
adamcstephens
requested changes
Nov 13, 2025
adamcstephens
approved these changes
Nov 13, 2025
nixpkgs-ci
bot
added
12.approvals: 1
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fish no longer sources most files in
$out/share/fishwith 4.2.0, and instead embeds these files in the fish binary itself:This means that any changes to these files now have to be made the input before the build system tries to embed them.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.